feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RunControl: Rename the misleading arg in createWorker()

Browse Source 
It describes run mode id, not worker id.

Change-Id: I0ddafdb20b2ce4aae6fede2ae289ae30498004ab
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-09-27 16:11:38 +02:00
parent eb1d34c32f
commit ab1abcef8b
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/runcontrol.cpp
View File

@@ -503,11 +503,11 @@ void RunControl::forceStop()
} }
} }
RunWorker *RunControl::createWorker(Id workerId) RunWorker *RunControl::createWorker(Id runMode)
{ {
const Id deviceType = DeviceTypeKitAspect::deviceTypeId(d->kit); const Id deviceType = DeviceTypeKitAspect::deviceTypeId(d->kit);
for (RunWorkerFactory *factory : std::as_const(g_runWorkerFactories)) { for (RunWorkerFactory *factory : std::as_const(g_runWorkerFactories)) {
if (factory->canCreate(workerId, deviceType, d->runConfigId.toString())) if (factory->canCreate(runMode, deviceType, d->runConfigId.toString()))
return factory->create(this); return factory->create(this);
} }
return nullptr; return nullptr;

2
src/plugins/projectexplorer/runcontrol.h
View File

@@ -228,7 +228,7 @@ public:
static void provideAskPassEntry(Utils::Environment &env); static void provideAskPassEntry(Utils::Environment &env);
RunWorker *createWorker(Utils::Id workerId); RunWorker *createWorker(Utils::Id runMode);
bool createMainWorker(); bool createMainWorker();
static bool canRun(Utils::Id runMode, Utils::Id deviceType, Utils::Id runConfigId); static bool canRun(Utils::Id runMode, Utils::Id deviceType, Utils::Id runConfigId);