From abb2236d4ba45e89bd189a97e5085040203f5f65 Mon Sep 17 00:00:00 2001
From: Mehdi Salem <mehdi.salem@qt.io>
Date: Wed, 21 Aug 2024 10:39:44 +0200
Subject: [PATCH] Axivion: check variant types for issue path links

Only create a link if both the values for 'path' and 'line' match the
expected types (string for 'path' and double for 'line' respectively).
If the types don't match we assume this to be a bug or corrupt data so
it justifies skipping the creation of the link entirely.

Change-Id: Iac923a5d268a80bc4b62f4744ad7b1d99a159db6
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
---
 src/plugins/axivion/axivionoutputpane.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/plugins/axivion/axivionoutputpane.cpp b/src/plugins/axivion/axivionoutputpane.cpp
index 5a3c0430c01..033a65bd717 100644
--- a/src/plugins/axivion/axivionoutputpane.cpp
+++ b/src/plugins/axivion/axivionoutputpane.cpp
@@ -516,10 +516,12 @@ static QList<LinkWithColumns> linksForIssue(const std::map<QString, Dto::Any> &i
         QList<int> columns;
         auto it = issueRow.find(path);
         if (it != end && !it->second.isNull()) {
+            QTC_ASSERT(it->second.isString(), return);
             Link link{ FilePath::fromUserInput(it->second.getString()) };
             columns.append(findColumn(it->first));
             it = issueRow.find(line);
-            if (it != end) {
+            if (it != end && !it->second.isNull()) {
+                QTC_ASSERT(it->second.isDouble(), return);
                 link.targetLine = it->second.getDouble();
                 columns.append(findColumn(it->first));
             }