CodeAssist: The correction is just used inside C++ proposal.

Adding an empty default implementation to the base and
Removing boilerplate code from the specialized classes.

Change-Id: I4469d9f05d2ff153c0867c10683f86b4f656fd3d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/texteditor/codeassist/functionhintproposal.cpp

@@ -42,14 +42,6 @@ bool FunctionHintProposal::isFragile() const
     return true;
 }
 
-bool FunctionHintProposal::isCorrective() const
-{
-    return false;
-}
-
-void FunctionHintProposal::makeCorrection(TextEditorWidget *)
-{}
-
 IAssistProposalModel *FunctionHintProposal::model() const
 {
     return m_model;

src/plugins/texteditor/codeassist/functionhintproposal.h

@@ -39,8 +39,6 @@ public:
     ~FunctionHintProposal();
 
     bool isFragile() const override;
-    bool isCorrective() const override;
-    void makeCorrection(TextEditorWidget *editorWidget) override;
     IAssistProposalModel *model() const override;
     IAssistProposalWidget *createWidget() const override;
 

src/plugins/texteditor/codeassist/genericproposal.cpp

@@ -49,14 +49,6 @@ bool GenericProposal::isFragile() const
     return false;
 }
 
-bool GenericProposal::isCorrective() const
-{
-    return false;
-}
-
-void GenericProposal::makeCorrection(TextEditorWidget *)
-{}
-
 IAssistProposalModel *GenericProposal::model() const
 {
     return m_model;

src/plugins/texteditor/codeassist/genericproposal.h

@@ -41,8 +41,6 @@ public:
     ~GenericProposal();
 
     bool isFragile() const override;
-    bool isCorrective() const override;
-    void makeCorrection(TextEditorWidget *editorWidget) override;
     IAssistProposalModel *model() const override;
     IAssistProposalWidget *createWidget() const override;
 

src/plugins/texteditor/codeassist/iassistproposal.cpp

@@ -93,12 +93,22 @@ int IAssistProposal::basePosition() const
     is displayed.
 */
 
+bool IAssistProposal::isCorrective() const
+{
+    return false;
+}
+
 /*!
     \fn void TextEditor::IAssistProposal::makeCorrection(BaseTextEditor *editor)
 
     This allows a correction to be made in the case this is a corrective proposal.
 */
 
+void IAssistProposal::makeCorrection(TextEditorWidget *editorWidget)
+{
+    Q_UNUSED(editorWidget);
+}
+
 /*!
     \fn IAssistModel *TextEditor::IAssistProposal::model() const
 

src/plugins/texteditor/codeassist/iassistproposal.h

@@ -41,8 +41,8 @@ public:
 
     int basePosition() const;
     virtual bool isFragile() const = 0;
-    virtual bool isCorrective() const = 0;
+    virtual bool isCorrective() const;
-    virtual void makeCorrection(TextEditorWidget *editorWidget) = 0;
+    virtual void makeCorrection(TextEditorWidget *editorWidget);
     virtual IAssistProposalModel *model() const = 0;
     virtual IAssistProposalWidget *createWidget() const = 0;