Editor: Do not allow changing document tab settings for clangformat

the clangformat plugin ignores our internal tab settings so there is no
need to be able to change those settings for files that are indented by
the clang format indenter.

Change-Id: I7b91f84e9ec4fbe977024aa648f49ea0b0dc6bcf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/clangformat/clangformatbaseindenter.cpp

@@ -1031,4 +1031,9 @@ void ClangFormatBaseIndenter::setOverriddenStyle(const clang::format::FormatStyl
     d->m_overriddenStyle = style;
 }
 
+bool ClangFormatBaseIndenter::respectsTabSettings() const
+{
+    return false;
+}
+
 } // namespace ClangFormat

src/plugins/clangformat/clangformatbaseindenter.h

@@ -55,6 +55,8 @@ public:
     void setOverriddenPreferences(TextEditor::ICodeStylePreferences *preferences) final;
     void setOverriddenStyle(const clang::format::FormatStyle &style);
 
+    bool respectsTabSettings() const override;
+
 protected:
     virtual bool formatCodeInsteadOfIndent() const { return false; }
     virtual bool formatWhileTyping() const { return false; }

src/plugins/clangformat/clangformatindenter.cpp

@@ -235,4 +235,9 @@ std::optional<int> ClangFormatForwardingIndenter::margin() const
     return currentIndenter()->margin();
 }
 
+bool ClangFormatForwardingIndenter::respectsTabSettings() const
+{
+    return currentIndenter()->respectsTabSettings();
+}
+
 } // namespace ClangFormat

src/plugins/clangformat/clangformatindenter.h

@@ -60,6 +60,8 @@ public:
                           int cursorPositionInEditor = -1) override;
     std::optional<int> margin() const override;
 
+    bool respectsTabSettings() const override;
+
 private:
     TextEditor::Indenter *currentIndenter() const;
 

src/plugins/texteditor/indenter.h

@@ -108,6 +108,8 @@ public:
 
     virtual std::optional<int> margin() const { return std::nullopt; }
 
+    virtual bool respectsTabSettings() const { return true; }
+
 protected:
     QTextDocument *m_doc;
     Utils::FilePath m_fileName;

src/plugins/texteditor/texteditor.cpp

@@ -314,9 +314,11 @@ private:
         QTC_ASSERT(m_doc, return);
         auto menu = new QMenu;
         menu->addAction(ActionManager::command(Constants::AUTO_INDENT_SELECTION)->action());
+        if (auto indenter = m_doc->indenter(); indenter && indenter->respectsTabSettings()) {
             auto documentSettings = menu->addMenu(Tr::tr("Document Settings"));
 
-        auto modifyTabSettings = [this](std::function<void(TabSettings &tabSettings)> modifier) {
+            auto modifyTabSettings =
+                [this](std::function<void(TabSettings & tabSettings)> modifier) {
                     return [this, modifier]() {
                         auto ts = m_doc->tabSettings();
                         modifier(ts);
@@ -359,6 +361,7 @@ private:
                         }));
                 }
                 tabSize->addActions(tabSizeGroup->actions());
+        }
 
         Id globalSettingsCategory;
         if (auto codeStyle = m_doc->codeStyle())