feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FormatTextEditor: Don't call blocking waitForStarted()

Browse Source 
This is unneeded when followed by waitForFinished().

Change-Id: I40a25e87bf5a5d1ece50715d72e2c48f4209344d
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Jarek Kobus
2022-06-29 17:44:30 +02:00
parent e22f50814d
commit ac4a4ded6c
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/texteditor/formattexteditor.cpp
View File

@@ -120,12 +120,6 @@ static FormatTask format(FormatTask task)
process.setCommand({FilePath::fromString(executable), options}); process.setCommand({FilePath::fromString(executable), options});
process.setWriteData(task.sourceData.toUtf8()); process.setWriteData(task.sourceData.toUtf8());
process.start(); process.start();
if (!process.waitForStarted(3000)) {
task.error = QString(QT_TRANSLATE_NOOP("TextEditor",
"Cannot call %1 or some other error occurred."))
.arg(executable);
return task;
}
if (!process.waitForFinished(5000)) { if (!process.waitForFinished(5000)) {
task.error = QString(QT_TRANSLATE_NOOP("TextEditor", task.error = QString(QT_TRANSLATE_NOOP("TextEditor",
"Cannot call %1 or some other error occurred. Timeout " "Cannot call %1 or some other error occurred. Timeout "