feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Don't expect the version in --help output

Browse Source 
Since we don't actually need it anymore, just remove the code.

Task-number: QTCREATORBUG-10452
Change-Id: I59f55f3a319240826569de308491cac697c4f045
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Daniel Teske
2013-10-22 15:51:21 +02:00
parent 3716791d0b
commit ac627bb770
2 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/cmakeprojectmanager/cmakevalidator.cpp
View File

@@ -86,16 +86,11 @@ void CMakeValidator::finished(int exitCode)
} }
if (m_state == CMakeValidator::RunningBasic) { if (m_state == CMakeValidator::RunningBasic) {
QByteArray response = m_process->readAll(); QByteArray response = m_process->readAll();
QRegExp versionRegexp(QLatin1String("^cmake version ([\\d\\.]*)"));
versionRegexp.indexIn(QString::fromLocal8Bit(response));
m_hasCodeBlocksMsvcGenerator = response.contains("CodeBlocks - NMake Makefiles"); m_hasCodeBlocksMsvcGenerator = response.contains("CodeBlocks - NMake Makefiles");
m_hasCodeBlocksNinjaGenerator = response.contains("CodeBlocks - Ninja"); m_hasCodeBlocksNinjaGenerator = response.contains("CodeBlocks - Ninja");
m_version = versionRegexp.cap(1);
if (versionRegexp.capturedTexts().size() > 3)
m_version += QLatin1Char('.') + versionRegexp.cap(3);
if (m_version.isEmpty()) { if (response.isEmpty()) {
m_state = CMakeValidator::Invalid; m_state = CMakeValidator::Invalid;
} else { } else {
m_state = CMakeValidator::RunningFunctionList; m_state = CMakeValidator::RunningFunctionList;

1
src/plugins/cmakeprojectmanager/cmakevalidator.h
View File

@@ -74,7 +74,6 @@ private:
QProcess *m_process; QProcess *m_process;
bool m_hasCodeBlocksMsvcGenerator; bool m_hasCodeBlocksMsvcGenerator;
bool m_hasCodeBlocksNinjaGenerator; bool m_hasCodeBlocksNinjaGenerator;
QString m_version;
QString m_executable; QString m_executable;
QMap<QString, QStringList> m_functionArgs; QMap<QString, QStringList> m_functionArgs;