From ac7fe92efe721fd495cbb71568551267e5de6cdc Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Tue, 5 Nov 2013 11:38:50 +0100 Subject: [PATCH] Remove disconnectClientSignals() from ~QmlProfilerClientManager() disconnectClientSignals only disconnects signals of objects that are deleted directly afterwards. As deleting a QObject automatically disconnects its signals it's unnecessary to explicitly do that before. However, if QmlProfilerClientManager is deleted from the destructor of QmlProfilerTool, receivers of those signals may have already been deleted. This can lead to crashes. Task-number: QTCREATORBUG-10634 Change-Id: I1e5ce7a6ac4b331fa423987e3a8faa3584b991d2 Reviewed-by: Kai Koehne --- src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp b/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp index d0fd1c77385..4c9c0810e56 100644 --- a/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp @@ -95,7 +95,6 @@ QmlProfilerClientManager::QmlProfilerClientManager(QObject *parent) : QmlProfilerClientManager::~QmlProfilerClientManager() { - disconnectClientSignals(); delete d->connection; delete d->qmlclientplugin.data(); delete d->v8clientplugin.data();