feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Vcs: Re-implement Fossil's topic indicator using a TopicCache sub-class

Browse Source 
The functionality for tracking project's current topic/branch has
long been folded into a base class Core::IVersionControl::TopicCache.
Fossil plugin should just sub-class it and pass the instance to the base.

Change-Id: I1b6c1631f5fc10987d8a608d573defeecbc31b37
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Artur Shepilko
2017-04-20 00:59:51 -05:00
parent 9086d2d11d
commit ac8005190d
3 changed files with 29 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
plugins/fossil/fossilclient.cpp
View File

@@ -568,36 +568,17 @@ QString FossilClient::synchronousGetRepositoryURL(const QString &workingDirector
return output;
}
struct TopicData
{
QDateTime timeStamp;
QString topic;
};
QString FossilClient::synchronousTopic(const QString &workingDirectory)
{
static QMap<QString, TopicData> topicCache;
if (workingDirectory.isEmpty())
return QString();
// return current branch name
const QString topLevel = findTopLevelForFile(workingDirectory);
const QFileInfo currentStateFile(topLevel + "/" + Constants::FOSSILREPO);
TopicData &data = topicCache[workingDirectory];
const QDateTime lastModified = currentStateFile.lastModified();
if (lastModified == data.timeStamp)
return data.topic;
const BranchInfo branchInfo = synchronousCurrentBranch(workingDirectory);
if (branchInfo.name().isEmpty())
return QString();
data.timeStamp = lastModified;
data.topic = branchInfo.name();
return data.topic;
return branchInfo.name();
}
bool FossilClient::synchronousCreateRepository(const QString &workingDirectory, const QStringList &extraOptions)