From ac87bca1514f2ff41e5868abe30624f0c57d9687 Mon Sep 17 00:00:00 2001 From: Christian Kamm Date: Mon, 15 Aug 2011 13:10:08 +0200 Subject: [PATCH] C++: Make Source::revision unsigned instead of int. All places that use it deal with unsigned revisions: * SemanticInfo::revision * Document::revision * CPPEditorWidget::editorRevision Even though QTextDocument::revision is int. Change-Id: I2b3a94056d15fd02539d14c7cec35511abed57b5 Reviewed-on: http://codereview.qt.nokia.com/2954 Reviewed-by: Leandro T. C. Melo --- src/plugins/cppeditor/cppeditor.cpp | 2 +- src/plugins/cppeditor/cppeditor.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/cppeditor/cppeditor.cpp b/src/plugins/cppeditor/cppeditor.cpp index 420d64fbc38..bc07e4ffbc8 100644 --- a/src/plugins/cppeditor/cppeditor.cpp +++ b/src/plugins/cppeditor/cppeditor.cpp @@ -2159,7 +2159,7 @@ SemanticInfo SemanticHighlighter::semanticInfo(const Source &source) m_mutex.lock(); if (! source.force - && m_lastSemanticInfo.revision == (unsigned)source.revision + && m_lastSemanticInfo.revision == source.revision && m_lastSemanticInfo.doc && m_lastSemanticInfo.doc->translationUnit()->ast() && m_lastSemanticInfo.doc->fileName() == source.fileName) { diff --git a/src/plugins/cppeditor/cppeditor.h b/src/plugins/cppeditor/cppeditor.h index 6b7cc87de12..a90026fcf40 100644 --- a/src/plugins/cppeditor/cppeditor.h +++ b/src/plugins/cppeditor/cppeditor.h @@ -92,7 +92,7 @@ public: QString code; int line; int column; - int revision; + unsigned revision; bool force; Source() @@ -103,7 +103,7 @@ public: const QString &fileName, const QString &code, int line, int column, - int revision) + unsigned revision) : snapshot(snapshot), fileName(fileName), code(code), line(line), column(column), revision(revision), force(false)