feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: Make Source::revision unsigned instead of int.

Browse Source 
All places that use it deal with unsigned revisions:
* SemanticInfo::revision
* Document::revision
* CPPEditorWidget::editorRevision

Even though QTextDocument::revision is int.

Change-Id: I2b3a94056d15fd02539d14c7cec35511abed57b5
Reviewed-on: http://codereview.qt.nokia.com/2954
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
This commit is contained in:
Christian Kamm
2011-08-15 13:10:08 +02:00
parent 1c3dab2948
commit ac87bca151
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cppeditor/cppeditor.cpp
View File

@@ -2159,7 +2159,7 @@ SemanticInfo SemanticHighlighter::semanticInfo(const Source &source)
m_mutex.lock(); m_mutex.lock();
if (! source.force if (! source.force
&& m_lastSemanticInfo.revision == (unsigned)source.revision && m_lastSemanticInfo.revision == source.revision
&& m_lastSemanticInfo.doc && m_lastSemanticInfo.doc
&& m_lastSemanticInfo.doc->translationUnit()->ast() && m_lastSemanticInfo.doc->translationUnit()->ast()
&& m_lastSemanticInfo.doc->fileName() == source.fileName) { && m_lastSemanticInfo.doc->fileName() == source.fileName) {

4
src/plugins/cppeditor/cppeditor.h
View File

@@ -92,7 +92,7 @@ public:
QString code; QString code;
int line; int line;
int column; int column;
int revision; unsigned revision;
bool force; bool force;
Source() Source()
@@ -103,7 +103,7 @@ public:
const QString &fileName, const QString &fileName,
const QString &code, const QString &code,
int line, int column, int line, int column,
int revision) unsigned revision)
: snapshot(snapshot), fileName(fileName), : snapshot(snapshot), fileName(fileName),
code(code), line(line), column(column), code(code), line(line), column(column),
revision(revision), force(false) revision(revision), force(false)