Changing string based api to BuildConfiguration based api.

Builds, but I'm pretty sure it doesn't *work* :)

src/plugins/projectexplorer/buildconfiguration.cpp

@@ -29,6 +29,8 @@
 
 #include "buildconfiguration.h"
 
+#include <utils/qtcassert.h>
+
 using namespace ProjectExplorer;
 
 BuildConfiguration::BuildConfiguration()
@@ -46,20 +48,21 @@ BuildConfiguration::BuildConfiguration(const QString &name, BuildConfiguration *
 {
 }
 
+void BuildConfiguration::setName(const QString &name)
+{
+    m_name = name;
+}
+
 QString BuildConfiguration::name() const
 {
     return m_name;
 }
 
-QString BuildConfiguration::displayName()
+QString BuildConfiguration::displayName() const
 {
     QVariant v = value("ProjectExplorer.BuildConfiguration.DisplayName");
-    if (v.isValid()) {
-        return v.toString();
-    } else {
-        setDisplayName(m_name);
-        return m_name;
-    }
+    QTC_ASSERT(v.isValid(), return QString());
+    return v.toString();
 }
 
 void BuildConfiguration::setDisplayName(const QString &name)
@@ -98,3 +101,14 @@ QMap<QString, QVariant> BuildConfiguration::toMap() const
         result.insert(it.key(), it.value());
     return result;
 }
+
+
+IBuildConfigurationFactory::IBuildConfigurationFactory(QObject *parent)
+    : QObject(parent)
+{
+}
+
+IBuildConfigurationFactory::~IBuildConfigurationFactory()
+{
+
+}