From acc00801463ab5ca6a1c4f57677484172b58c3ad Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 16 May 2019 17:38:35 +0200 Subject: [PATCH] QmakeProject: Make QMakeBuildConfiguration less visible ... in QmakeMakeStep interface. Change-Id: I19bfa0470dc709d79563640bc4dc4f7fc0d5d8f3 Reviewed-by: Christian Kandeler --- src/plugins/qmakeprojectmanager/qmakemakestep.cpp | 7 +------ src/plugins/qmakeprojectmanager/qmakemakestep.h | 5 ----- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/plugins/qmakeprojectmanager/qmakemakestep.cpp b/src/plugins/qmakeprojectmanager/qmakemakestep.cpp index 176df4cad1c..d143637c3ff 100644 --- a/src/plugins/qmakeprojectmanager/qmakemakestep.cpp +++ b/src/plugins/qmakeprojectmanager/qmakemakestep.cpp @@ -64,14 +64,9 @@ QmakeMakeStep::QmakeMakeStep(BuildStepList *bsl) } } -QmakeBuildConfiguration *QmakeMakeStep::qmakeBuildConfiguration() const -{ - return static_cast(buildConfiguration()); -} - bool QmakeMakeStep::init() { - QmakeBuildConfiguration *bc = qmakeBuildConfiguration(); + const auto bc = static_cast(buildConfiguration()); if (!bc) emit addTask(Task::buildConfigurationMissingTask()); diff --git a/src/plugins/qmakeprojectmanager/qmakemakestep.h b/src/plugins/qmakeprojectmanager/qmakemakestep.h index d1d78d19991..a1bd2b16493 100644 --- a/src/plugins/qmakeprojectmanager/qmakemakestep.h +++ b/src/plugins/qmakeprojectmanager/qmakemakestep.h @@ -30,9 +30,6 @@ #include namespace QmakeProjectManager { - -class QmakeBuildConfiguration; - namespace Internal { class QmakeMakeStepFactory : public ProjectExplorer::BuildStepFactory @@ -52,8 +49,6 @@ class QMAKEPROJECTMANAGER_EXPORT QmakeMakeStep : public ProjectExplorer::MakeSte public: explicit QmakeMakeStep(ProjectExplorer::BuildStepList *bsl); - QmakeBuildConfiguration *qmakeBuildConfiguration() const; - private: void finish(bool success) override; bool init() override;