feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Always use commit hash in archive

Browse Source 
Storing the archive as "Project-HEAD" or even
"Project-master" is ambiguous.

Better resolve the reference to to have unique
archive identifiers.

Change-Id: I1233c20e5975028d084d6587b4a0f47390d1fd17
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2019-12-20 21:36:22 +01:00
committed by André Hartmann
parent 31e9c93b6b
commit acd1d6c438
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/git/gitclient.cpp
View File

@@ -1131,7 +1131,7 @@ void GitClient::show(const QString &source, const QString &id, const QString &na
});
}
void GitClient::archive(const QString &workingDirectory, const QString &commit)
void GitClient::archive(const QString &workingDirectory, QString commit)
{
QString repoDirectory = VcsManager::findTopLevelForDirectory(workingDirectory);
if (repoDirectory.isEmpty())
@@ -1148,6 +1148,10 @@ void GitClient::archive(const QString &workingDirectory, const QString &commit)
else
selectedFilter = filters.key(".tar.gz");
QString output;
if (synchronousRevParseCmd(repoDirectory, commit, &output))
commit = output.trimmed();
QString archiveName = QFileDialog::getSaveFileName(
ICore::dialogParent(),
tr("Generate %1 archive").arg(repoName),