Sqlite: Fix null handling

Most of it is only silencing a warning but one is fixing a faulty test. So
writing null values should now be working.

Change-Id: If702e1fc8176a9e0ae82a5589c719d567929202b
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>

src/libs/sqlite/createtablesqlstatementbuilder.cpp

@@ -192,6 +192,8 @@ public:
             columnDefinitionString.append(defaultValue.value.toStringView());
             columnDefinitionString.append("'");
             break;
+        default:
+            break;
         }
     }
 

src/libs/sqlite/sqlitebasestatement.cpp

@@ -214,6 +214,9 @@ void BaseStatement::bind(int index, const Value &value)
     case ValueType::String:
         bind(index, value.toStringView());
         break;
+    case ValueType::Null:
+        bind(index, NullValue{});
+        break;
     }
 }
 

src/libs/sqlite/sqlitevalue.h

@@ -102,6 +102,8 @@ public:
             return QVariant(toFloat());
         case ValueType::String:
             return QVariant(QString(toStringView()));
+        case ValueType::Null:
+            break;
         }
 
         return {};
@@ -281,6 +283,8 @@ public:
             return first.toFloat() == second.toFloat();
         case ValueType::String:
             return first.toStringView() == second.toStringView();
+        case ValueType::Null:
+            return false;
         }
 
         return false;

tests/unit/unittest/gtest-creator-printing.cpp

@@ -320,6 +320,9 @@ std::ostream &operator<<(std::ostream &out, const Value &value)
     case Sqlite::ValueType::String:
         out << "\"" << value.toStringView() << "\"";
         break;
+    case Sqlite::ValueType::Null:
+        out << "null";
+        break;
     }
 
     return out << ")";

tests/unit/unittest/sqlitestatement-test.cpp

@@ -388,6 +388,7 @@ TEST_F(SqliteStatement, WritePointerValues)
 TEST_F(SqliteStatement, WriteNullValues)
 {
     WriteStatement statement("UPDATE test SET name=?, number=? WHERE rowid=?", database);
+    statement.write(1, 1, 1);
 
     statement.write(Sqlite::NullValue{}, Sqlite::Value{}, 1);