Project explorer: Make public headers compile with NO_CAST_FROM_ASCII

.. and purge unneeded includes.

src/plugins/cmakeprojectmanager/cmakebuildenvironmentwidget.cpp

@@ -31,6 +31,7 @@
 #include "cmakeproject.h"
 #include <projectexplorer/environmenteditmodel.h>
 #include <QtGui/QVBoxLayout>
+#include <QtGui/QCheckBox>
 
 namespace {
 bool debug = false;

src/plugins/cmakeprojectmanager/makestep.cpp

@@ -30,6 +30,8 @@
 #include "cmakeprojectconstants.h"
 #include "cmakeproject.h"
 
+#include <projectexplorer/projectexplorer.h>
+
 #include <QtGui/QFormLayout>
 #include <QtGui/QGroupBox>
 #include <QtGui/QCheckBox>

src/plugins/debugger/debuggerplugin.cpp

@@ -66,6 +66,7 @@
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/session.h>
+#include <projectexplorer/project.h>
 
 #include <texteditor/basetexteditor.h>
 #include <texteditor/basetextmark.h>

src/plugins/genericprojectmanager/genericmakestep.cpp

@@ -34,6 +34,7 @@
 
 #include <extensionsystem/pluginmanager.h>
 #include <projectexplorer/toolchain.h>
+#include <projectexplorer/projectexplorer.h>
 #include <utils/qtcassert.h>
 #include <coreplugin/variablemanager.h>
 

src/plugins/genericprojectmanager/genericproject.cpp

@@ -33,6 +33,7 @@
 
 #include <projectexplorer/toolchain.h>
 #include <projectexplorer/projectexplorerconstants.h>
+#include <projectexplorer/persistentsettings.h>
 #include <cpptools/cppmodelmanagerinterface.h>
 #include <extensionsystem/pluginmanager.h>
 #include <utils/pathchooser.h>

src/plugins/git/gitplugin.cpp

@@ -58,6 +58,7 @@
 
 #include <projectexplorer/projectexplorer.h>
 #include <projectexplorer/project.h>
+#include <projectexplorer/projectnodes.h>
 
 #include <QtCore/QDebug>
 #include <QtCore/QDir>

src/plugins/projectexplorer/abstractmakestep.cpp

@@ -30,6 +30,7 @@
 #include "abstractmakestep.h"
 
 #include "projectexplorerconstants.h"
+#include "project.h"
 
 #include <extensionsystem/pluginmanager.h>
 #include <utils/qtcassert.h>

src/plugins/projectexplorer/abstractmakestep.h

@@ -30,9 +30,8 @@
 #ifndef ABSTRACTMAKESTEP_H
 #define ABSTRACTMAKESTEP_H
 
-#include "abstractprocessstep.h"
-#include "projectexplorer.h"
 #include "projectexplorer_export.h"
+#include "abstractprocessstep.h"
 
 namespace ProjectExplorer {
 class BuildStep;

src/plugins/projectexplorer/buildmanager.cpp

@@ -34,6 +34,7 @@
 #include "compileoutputwindow.h"
 #include "projectexplorerconstants.h"
 #include "projectexplorer.h"
+#include "project.h"
 #include "projectexplorersettings.h"
 #include "taskwindow.h"
 
@@ -45,6 +46,9 @@
 
 #include <QtCore/QDir>
 #include <QtCore/QTimer>
+
+#include <qtconcurrent/QtConcurrentTools>
+
 #include <QtGui/QHeaderView>
 #include <QtGui/QIcon>
 #include <QtGui/QLabel>

src/plugins/projectexplorer/buildmanager.h

@@ -36,9 +36,7 @@
 #include <QtCore/QStringList>
 #include <QtCore/QList>
 #include <QtCore/QHash>
-#include <QtCore/QtConcurrentRun>
 #include <QtCore/QFutureWatcher>
-#include <qtconcurrent/QtConcurrentTools>
 
 namespace ProjectExplorer {
 

src/plugins/projectexplorer/buildsettingspropertiespage.cpp

@@ -40,6 +40,7 @@
 #include <QtGui/QInputDialog>
 #include <QtGui/QLabel>
 #include <QtGui/QVBoxLayout>
+#include <QtGui/QMenu>
 
 using namespace ProjectExplorer;
 using namespace ProjectExplorer::Internal;

src/plugins/projectexplorer/buildstep.cpp

@@ -29,6 +29,7 @@
 
 #include "buildstep.h"
 #include "buildconfiguration.h"
+#include "project.h"
 
 #include <utils/qtcassert.h>
 #include <QtGui/QLayout>

src/plugins/projectexplorer/buildstep.h

@@ -31,7 +31,6 @@
 #define BUILDSTEP_H
 
 #include "buildparserinterface.h"
-#include "project.h"
 #include "projectexplorer_export.h"
 
 #include <QtGui/QWidget>
@@ -39,6 +38,7 @@
 
 namespace ProjectExplorer {
 
+class Project;
 namespace Internal {
 class BuildConfiguration;
 }

src/plugins/projectexplorer/buildstepspage.cpp

@@ -39,6 +39,7 @@
 
 #include <QtGui/QLabel>
 #include <QtGui/QPushButton>
+#include <QtGui/QMenu>
 
 using namespace ProjectExplorer;
 using namespace ProjectExplorer::Internal;

src/plugins/projectexplorer/customexecutablerunconfiguration.cpp

@@ -30,10 +30,13 @@
 #include "customexecutablerunconfiguration.h"
 #include "environment.h"
 #include "project.h"
+#include "persistentsettings.h"
+#include "environmenteditmodel.h"
 
 #include <coreplugin/icore.h>
 #include <projectexplorer/debugginghelper.h>
 #include <utils/detailsbutton.h>
+#include <utils/pathchooser.h>
 
 #include <QtGui/QCheckBox>
 #include <QtGui/QFormLayout>

src/plugins/projectexplorer/customexecutablerunconfiguration.h

@@ -32,19 +32,24 @@
 
 #include "applicationrunconfiguration.h"
 
-#include <utils/pathchooser.h>
-#include <projectexplorer/environmenteditmodel.h>
-
-#include <QtGui/QToolButton>
+#include <QtGui/QWidget>
 
 QT_BEGIN_NAMESPACE
 class QCheckBox;
 class QLineEdit;
 class QComboBox;
+class QLabel;
+class QAbstractButton;
 QT_END_NAMESPACE
 
+namespace Core {
+namespace Utils {
+class PathChooser;
+}
+}
+
 namespace ProjectExplorer {
-    
+class EnvironmentWidget;
 namespace Internal {
     class CustomExecutableConfigurationWidget;
 }

src/plugins/projectexplorer/dependenciespanel.cpp

@@ -34,6 +34,7 @@
 #include <utils/detailsbutton.h>
 
 #include <coreplugin/fileiconprovider.h>
+#include <coreplugin/ifile.h>
 
 #include <QtCore/QVector>
 #include <QtCore/QDebug>

src/plugins/projectexplorer/editorsettingspropertiespage.cpp

@@ -29,6 +29,7 @@
 
 #include "editorsettingspropertiespage.h"
 #include "editorconfiguration.h"
+#include "project.h"
 
 #include <QtCore/QTextCodec>
 

src/plugins/projectexplorer/environment.h

@@ -72,8 +72,8 @@ public:
     void unset(const QString &key);
     void modify(const QList<EnvironmentItem> & list);
 
-    void appendOrSet(const QString &key, const QString &value, const QString &sep = "");
-    void prependOrSet(const QString &key, const QString &value, const QString &sep = "");
+    void appendOrSet(const QString &key, const QString &value, const QString &sep = QString());
+    void prependOrSet(const QString &key, const QString &value, const QString &sep = QString());
 
     void appendOrSetPath(const QString &value);
     void prependOrSetPath(const QString &value);

src/plugins/projectexplorer/environmenteditmodel.cpp

@@ -34,6 +34,13 @@
 #include <QtGui/QVBoxLayout>
 #include <QtGui/QHeaderView>
 #include <QtGui/QToolButton>
+#include <QtCore/QDebug>
+#include <QtGui/QWidget>
+#include <QtGui/QCheckBox>
+#include <QtGui/QTreeView>
+#include <QtGui/QPushButton>
+#include <QtGui/QLabel>
+#include <QtGui/QStackedWidget>
 
 using namespace ProjectExplorer;
 

src/plugins/projectexplorer/environmenteditmodel.h

@@ -34,13 +34,15 @@
 
 #include <QtCore/QString>
 #include <QtCore/QAbstractItemModel>
-#include <QtCore/QDebug>
 #include <QtGui/QWidget>
-#include <QtGui/QCheckBox>
-#include <QtGui/QTreeView>
-#include <QtGui/QPushButton>
-#include <QtGui/QLabel>
-#include <QtGui/QStackedWidget>
+
+QT_BEGIN_NAMESPACE
+class QCheckBox;
+class QTreeView;
+class QPushButton;
+class QLabel;
+class QStackedWidget;
+QT_END_NAMESPACE
 
 namespace ProjectExplorer {
 

src/plugins/projectexplorer/iprojectproperties.h

@@ -31,12 +31,11 @@
 #define IPROJECTPROPERTIES_H
 
 #include "projectexplorer_export.h"
-#include "project.h"
 
 #include <coreplugin/icontext.h>
 
 namespace ProjectExplorer {
-
+class Project;
 class PropertiesPanel;
 
 class PROJECTEXPLORER_EXPORT IPanelFactory : public QObject

src/plugins/projectexplorer/persistentsettings.cpp

@@ -34,6 +34,7 @@
 #include <QtCore/QVariant>
 #include <QtXml/QDomDocument>
 #include <QtXml/QDomCDATASection>
+#include <QtXml/QDomElement>
 
 
 using namespace ProjectExplorer;

src/plugins/projectexplorer/persistentsettings.h

@@ -34,7 +34,10 @@
 
 #include <QtCore/QMap>
 #include <QtCore/QVariant>
-#include <QtXml/QDomElement>
+
+QT_BEGIN_NAMESPACE
+class QDomElement;
+QT_END_NAMESPACE
 
 namespace ProjectExplorer {
 

src/plugins/projectexplorer/project.cpp

@@ -29,6 +29,10 @@
 
 #include "project.h"
 
+#include "persistentsettings.h"
+#include "buildconfiguration.h"
+#include "environment.h"
+#include "projectnodes.h"
 #include "buildstep.h"
 #include "projectexplorer.h"
 #include "runconfiguration.h"

src/plugins/projectexplorer/project.h

@@ -30,19 +30,15 @@
 #ifndef PROJECT_H
 #define PROJECT_H
 
-#include "persistentsettings.h"
 #include "projectexplorer_export.h"
-#include "buildconfiguration.h"
-#include "environment.h"
-#include "projectnodes.h"
 
 #include <QtCore/QSharedPointer>
 #include <QtCore/QObject>
-#include <QtCore/QModelIndex>
-#include <QtCore/QFileInfo>
 #include <QtGui/QFileSystemModel>
-#include <QtGui/QMenu>
-#include <QtGui/QIcon>
+
+QT_BEGIN_NAMESPACE
+class QMenu;
+QT_END_NAMESPACE
 
 namespace Core {
 class IFile;
@@ -56,6 +52,14 @@ class BuildConfigWidget;
 class IProjectManager;
 class RunConfiguration;
 class EditorConfiguration;
+class Environment;
+class ProjectNode;
+class PersistentSettingsWriter;
+class PersistentSettingsReader;
+
+namespace Internal {
+class BuildConfiguration;
+}
 
 class PROJECTEXPLORER_EXPORT Project
     : public QObject

src/plugins/projectexplorer/projectexplorer.cpp

@@ -28,6 +28,7 @@
 **************************************************************************/
 
 #include "projectexplorer.h"
+#include "project.h"
 #include "projectexplorersettings.h"
 #include "applicationrunconfiguration.h"
 #include "allprojectsfilter.h"

src/plugins/projectexplorer/projectmodels.cpp

@@ -31,6 +31,7 @@
 
 #include "project.h"
 #include "projectexplorerconstants.h"
+#include "projectnodes.h"
 
 #include <coreplugin/fileiconprovider.h>
 #include <utils/qtcassert.h>

src/plugins/projectexplorer/projecttreewidget.cpp

@@ -48,6 +48,7 @@
 #include <QtGui/QFocusEvent>
 #include <QtGui/QAction>
 #include <QtGui/QPalette>
+#include <QtGui/QMenu>
 
 using namespace ProjectExplorer;
 using namespace ProjectExplorer::Internal;

src/plugins/projectexplorer/projectwindow.cpp

@@ -30,6 +30,7 @@
 #include "projectwindow.h"
 
 #include "project.h"
+#include "environment.h"
 #include "projectexplorer.h"
 #include "projectexplorerconstants.h"
 #include "iprojectproperties.h"
@@ -40,6 +41,7 @@
 #include <coreplugin/minisplitter.h>
 #include <coreplugin/fileiconprovider.h>
 #include <coreplugin/icore.h>
+#include <coreplugin/ifile.h>
 #include <extensionsystem/pluginmanager.h>
 #include <utils/styledbar.h>
 

src/plugins/projectexplorer/runconfiguration.cpp

@@ -29,6 +29,7 @@
 
 #include "runconfiguration.h"
 #include "project.h"
+#include "persistentsettings.h"
 
 #include <QtCore/QTimer>
 

src/plugins/projectexplorer/runsettingspropertiespage.cpp

@@ -29,6 +29,7 @@
 
 #include "runsettingspropertiespage.h"
 #include "runconfiguration.h"
+#include "project.h"
 
 #include "ui_runsettingspropertiespage.h"
 
@@ -38,6 +39,7 @@
 
 #include <QtCore/QDebug>
 #include <QtCore/QPair>
+#include <QtGui/QMenu>
 
 namespace ProjectExplorer {
 namespace Internal {

src/plugins/projectexplorer/runsettingspropertiespage.h

@@ -34,6 +34,10 @@
 
 #include <QtGui/QWidget>
 
+QT_BEGIN_NAMESPACE
+class QMenu;
+QT_END_NAMESPACE
+
 namespace ProjectExplorer {
 namespace Internal {
 

src/plugins/projectexplorer/session.cpp

@@ -34,6 +34,7 @@
 #include "projectexplorerconstants.h"
 #include "nodesvisitor.h"
 #include "editorconfiguration.h"
+#include "persistentsettings.h"
 
 #include <coreplugin/icore.h>
 #include <coreplugin/imode.h>

src/plugins/projectexplorer/session.h

@@ -33,19 +33,20 @@
 #include "projectexplorer_export.h"
 #include "projectnodes.h"
 
-#include <coreplugin/ifile.h>
-
-#include <QtCore/QObject>
-#include <QtCore/QAbstractItemModel>
 #include <QtCore/QHash>
 #include <QtCore/QList>
 #include <QtCore/QString>
 #include <QtCore/QStringList>
 
+QT_BEGIN_NAMESPACE
+class QAbstractItemModel;
+QT_END_NAMESPACE
+
 namespace Core {
 class ICore;
 class IMode;
 class IEditor;
+class IFile;
 }
 
 namespace ProjectExplorer {

src/plugins/projectexplorer/toolchain.cpp

@@ -28,6 +28,7 @@
 **************************************************************************/
 
 #include "toolchain.h"
+#include "project.h"
 #include "cesdkhandler.h"
 #include "projectexplorersettings.h"
 

src/plugins/projectexplorer/toolchain.h

@@ -30,13 +30,18 @@
 #ifndef TOOLCHAIN_H
 #define TOOLCHAIN_H
 
+#include "projectexplorer_export.h"
 #include "environment.h"
-#include "project.h"
+
 #include <QtCore/QString>
 #include <QtCore/QPair>
+#include <QtCore/QMetaType>
 
 namespace ProjectExplorer {
 
+class Environment;
+class Project;
+
 class PROJECTEXPLORER_EXPORT HeaderPath
 {
 public:

src/plugins/qmlprojectmanager/qmlproject.cpp

@@ -32,6 +32,7 @@
 #include "qmlmakestep.h"
 
 #include <projectexplorer/toolchain.h>
+#include <projectexplorer/persistentsettings.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <extensionsystem/pluginmanager.h>
 #include <utils/pathchooser.h>

src/plugins/qt4projectmanager/qt-s60/s60devicerunconfiguration.cpp

@@ -41,6 +41,7 @@
 #include <utils/qtcassert.h>
 #include <utils/pathchooser.h>
 #include <projectexplorer/projectexplorerconstants.h>
+#include <projectexplorer/persistentsettings.h>
 #include <projectexplorer/project.h>
 
 #include <debugger/debuggermanager.h>

src/plugins/qt4projectmanager/qt-s60/s60emulatorrunconfiguration.cpp

@@ -40,6 +40,7 @@
 #include <utils/qtcassert.h>
 #include <projectexplorer/projectexplorerconstants.h>
 #include <projectexplorer/project.h>
+#include <projectexplorer/persistentsettings.h>
 
 using namespace ProjectExplorer;
 using namespace Qt4ProjectManager::Internal;

src/plugins/qt4projectmanager/qt4buildenvironmentwidget.cpp

@@ -32,6 +32,8 @@
 
 #include <projectexplorer/environmenteditmodel.h>
 
+#include <QtGui/QCheckBox>
+
 namespace {
 bool debug = false;
 }

src/plugins/qt4projectmanager/qt4runconfiguration.cpp

@@ -40,6 +40,7 @@
 #include <coreplugin/ifile.h>
 #include <projectexplorer/buildstep.h>
 #include <projectexplorer/environmenteditmodel.h>
+#include <projectexplorer/persistentsettings.h>
 #include <utils/qtcassert.h>
 #include <utils/detailsbutton.h>