feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Android: Don't use --server argument to lldb-server

Browse Source 
We are not re-using the server process currently, and servers surviving
their processes seems to lead to zombie server processes (on app
uninstall(?))

Change-Id: I996fcd490e98a5101840cbbab5f640abf1f2d90b
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
This commit is contained in:
hjk
2020-05-26 15:07:35 +02:00
parent 301a388982
commit ad379227a9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/android/androidrunnerworker.cpp
View File

@@ -627,7 +627,7 @@ bool AndroidRunnerWorker::startDebuggerServer(const QString &packageDir,
QStringList lldbServerArgs = selector(); QStringList lldbServerArgs = selector();
lldbServerArgs << "shell" << "run-as" << m_packageName << debugServerFile lldbServerArgs << "shell" << "run-as" << m_packageName << debugServerFile
<< "platform" << "platform"
<< "--server" // << "--server" // Can lead to zombie servers
<< "--listen" << QString("*:%1").arg(m_localDebugServerPort.toString()); << "--listen" << QString("*:%1").arg(m_localDebugServerPort.toString());
m_debugServerProcess.reset(AndroidManager::runAdbCommandDetached(lldbServerArgs, &lldbServerErr)); m_debugServerProcess.reset(AndroidManager::runAdbCommandDetached(lldbServerArgs, &lldbServerErr));