feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

GenericProject: Normalize make step setup

Browse Source 
We have only one id for the steps, so short of coming up with some
fancy upgrade mechanism, stick to the one kind of step, but also
use only one factory, and do the switch in the step constructor
based on the nature of the parent buildsteplist.

Change-Id: I8fcc599682840d61e4a7f8b6fb7b792aafdd8766
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-07-30 13:45:05 +02:00
parent 0d6468a8af
commit ad99e150cc
5 changed files with 19 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/genericprojectmanager/genericbuildconfiguration.cpp
View File

@@ -63,10 +63,10 @@ void GenericBuildConfiguration::initialize(const BuildInfo &info)
BuildConfiguration::initialize(info);
BuildStepList *buildSteps = stepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD);
buildSteps->appendStep(new GenericMakeStep(buildSteps, "all"));
buildSteps->appendStep(Constants::GENERIC_MS_ID);
BuildStepList *cleanSteps = stepList(ProjectExplorer::Constants::BUILDSTEPS_CLEAN);
cleanSteps->appendStep(new GenericMakeStep(cleanSteps, "clean"));
cleanSteps->appendStep(Constants::GENERIC_MS_ID);
updateCacheAndEmitEnvironmentChanged();
}