feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix coding style for else statements

Browse Source 
Change-Id: I1309db70e98d678e150388c76ce665e988fdf081
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
This commit is contained in:
Orgad Shaneh
2013-07-17 00:01:45 +03:00
committed by Orgad Shaneh
parent c67f7f6349
commit ad9e7ccab6
101 changed files with 331 additions and 470 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -408,8 +408,7 @@ void CallgrindToolPrivate::handleFilterProjectCosts()
if (m_filterProjectCosts->isChecked()) {
const QString projectDir = pro->projectDirectory();
m_proxyModel->setFilterBaseDir(projectDir);
}
else {
} else {
m_proxyModel->setFilterBaseDir(QString());
}
}

7
src/plugins/valgrind/callgrindvisualisation.cpp
View File

@@ -188,8 +188,7 @@ void FunctionGraphicsItem::paint(QPainter *painter,
gradient.setColorAt(0.5, color.lighter(200));
gradient.setColorAt(1, color.darker(100));
painter->setBrush(gradient);
}
else {
} else {
painter->setBrush(color);
}
@@ -256,9 +255,9 @@ void Visualisation::Private::handleMousePressEvent(QMouseEvent *event,
if (itemAtPos) {
const Function *func = q->functionForItem(itemAtPos);
if (doubleClicked)
if (doubleClicked) {
q->functionActivated(func);
else {
} else {
q->scene()->clearSelection();
itemAtPos->setSelected(true);
q->functionSelected(func);

25
src/plugins/valgrind/xmlprotocol/parser.cpp
View File

@@ -440,29 +440,27 @@ void Parser::Private::parseError()
if (reader.isStartElement())
lastAuxWhat++;
const QStringRef name = reader.name();
if (name == QLatin1String("unique"))
if (name == QLatin1String("unique")) {
e.setUnique(parseHex(blockingReadElementText(), QLatin1String("unique")));
else if (name == QLatin1String("tid"))
} else if (name == QLatin1String("tid")) {
e.setTid(parseInt64(blockingReadElementText(), QLatin1String("error/tid")));
else if (name == QLatin1String("kind")) //TODO this is memcheck-specific:
} else if (name == QLatin1String("kind")) { //TODO this is memcheck-specific:
e.setKind(parseErrorKind(blockingReadElementText()));
else if (name == QLatin1String("suppression"))
} else if (name == QLatin1String("suppression")) {
e.setSuppression(parseSuppression());
else if (name == QLatin1String("xwhat")) {
} else if (name == QLatin1String("xwhat")) {
const XWhat xw = parseXWhat();
e.setWhat(xw.text);
e.setLeakedBlocks(xw.leakedblocks);
e.setLeakedBytes(xw.leakedbytes);
e.setHelgrindThreadId(xw.hthreadid);
}
else if (name == QLatin1String("what"))
} else if (name == QLatin1String("what")) {
e.setWhat(blockingReadElementText());
else if (name == QLatin1String("xauxwhat")) {
} else if (name == QLatin1String("xauxwhat")) {
if (!currentAux.text.isEmpty())
auxs.push_back(currentAux);
currentAux = parseXauxWhat();
}
else if (name == QLatin1String("auxwhat")) {
} else if (name == QLatin1String("auxwhat")) {
const QString aux = blockingReadElementText();
//concatenate multiple consecutive <auxwhat> tags
if (lastAuxWhat > 1) {
@@ -476,12 +474,11 @@ void Parser::Private::parseError()
currentAux.text.append(aux);
}
lastAuxWhat = 0;
}
else if (name == QLatin1String("stack")) {
} else if (name == QLatin1String("stack")) {
frames.push_back(parseStack());
}
else if (reader.isStartElement())
} else if (reader.isStartElement()) {
reader.skipCurrentElement();
}
}
if (!currentAux.text.isEmpty())