feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

UnitTests: Fix names and disable slow tests by default

Browse Source 
Slow and very slow tests have now their own test category. We add SlowTest
for tests which are slower than ~5ms and VerySlowTest if they are slower
than ~100ms. They are disabled them by "-*SlowTest.*". If you have a faster
machine than most developers simply try lower values. The aim is that most
developers can execute the tests in under ~2s.

In the long run we should use dependency breaking and data sharing to
reduce the count of the slow tests.

Change-Id: I8578071258d7f89b2052709f3dd526ced811483f
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Marco Bubke
2017-01-04 11:39:17 +01:00
parent 719e6e0aff
commit ada5ea1952
27 changed files with 319 additions and 272 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/unit/unittest/diagnostic-test.cpp
View File

@@ -120,7 +120,9 @@ protected:
DiagnosticContainer expectedDiagnostic(ChildMode childMode) const;
};
TEST_F(Diagnostic, MoveContructor)
using DiagnosticSlowTest = Diagnostic;
TEST_F(DiagnosticSlowTest, MoveContructor)
{
const auto diagnostic2 = std::move(d->d->diagnostic);
@@ -128,7 +130,7 @@ TEST_F(Diagnostic, MoveContructor)
ASSERT_FALSE(diagnostic2.isNull());
}
TEST_F(Diagnostic, MoveAssigment)
TEST_F(DiagnosticSlowTest, MoveAssigment)
{
auto diagnostic2 = std::move(d->d->diagnostic);
d->d->diagnostic = std::move(diagnostic2);
@@ -137,53 +139,53 @@ TEST_F(Diagnostic, MoveAssigment)
ASSERT_FALSE(d->d->diagnostic.isNull());
}
TEST_F(Diagnostic, MoveSelfAssigment)
TEST_F(DiagnosticSlowTest, MoveSelfAssigment)
{
d->d->diagnostic = std::move(d->d->diagnostic);
ASSERT_FALSE(d->d->diagnostic.isNull());
}
TEST_F(Diagnostic, Text)
TEST_F(DiagnosticSlowTest, Text)
{
ASSERT_THAT(d->d->diagnostic.text(), Utf8StringLiteral("warning: control reaches end of non-void function"));
}
TEST_F(Diagnostic, Category)
TEST_F(DiagnosticSlowTest, Category)
{
ASSERT_THAT(d->d->diagnostic.category(), Utf8StringLiteral("Semantic Issue"));
}
TEST_F(Diagnostic, EnableOption)
TEST_F(DiagnosticSlowTest, EnableOption)
{
ASSERT_THAT(d->d->diagnostic.options().first, Utf8StringLiteral("-Wreturn-type"));
}
TEST_F(Diagnostic, DisableOption)
TEST_F(DiagnosticSlowTest, DisableOption)
{
ASSERT_THAT(d->d->diagnostic.options().second, Utf8StringLiteral("-Wno-return-type"));
}
TEST_F(Diagnostic, Severity)
TEST_F(DiagnosticSlowTest, Severity)
{
ASSERT_THAT(d->d->diagnostic.severity(), DiagnosticSeverity::Warning);
}
TEST_F(Diagnostic, ChildDiagnosticsSize)
TEST_F(DiagnosticSlowTest, ChildDiagnosticsSize)
{
auto diagnostic = d->d->diagnosticSet.back();
ASSERT_THAT(diagnostic.childDiagnostics().size(), 1);
}
TEST_F(Diagnostic, ChildDiagnosticsText)
TEST_F(DiagnosticSlowTest, ChildDiagnosticsText)
{
auto childDiagnostic = d->d->diagnosticSet.back().childDiagnostics().front();
ASSERT_THAT(childDiagnostic.text(), Utf8StringLiteral("note: candidate function not viable: requires 1 argument, but 0 were provided"));
}
TEST_F(Diagnostic, toDiagnosticContainerLetChildrenThroughByDefault)
TEST_F(DiagnosticSlowTest, toDiagnosticContainerLetChildrenThroughByDefault)
{
const auto diagnosticWithChild = expectedDiagnostic(WithChild);