From 83ddbaad23c321d13244e5e00a0e16b85b0b0a82 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 21 Nov 2022 11:55:31 +0100 Subject: [PATCH 1/5] More change log for 9.0.0 Change-Id: I6741608b5d474c85cffc82b1d9fe11fa793f0279 Reviewed-by: Leena Miettinen --- dist/changelog/changes-9.0.0.md | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/dist/changelog/changes-9.0.0.md b/dist/changelog/changes-9.0.0.md index ff68a247cc2..3997f62bab0 100644 --- a/dist/changelog/changes-9.0.0.md +++ b/dist/changelog/changes-9.0.0.md @@ -42,6 +42,7 @@ Editing * Fixed saving files with non-breaking spaces (QTCREATORBUG-17875) * Fixed `Rewrap Paragraph` for Doxygen comments (QTCREATORBUG-9739) * Fixed MIME type matching for generic highlighting with MIME type aliases +* Fixed annotation painting when scrolling horizontally (QTCREATORBUG-28411) ### C++ @@ -55,6 +56,7 @@ Editing action (QTCREATORBUG-28099) * Fixed that selection was not considered for refactoring actions (QTCREATORBUG-27886) +* Fixed generation of function definitions with `unsigned` (QTCREATORBUG-28378) * Fixed code style preview editor size (QTCREATORBUG-27267) * Clangd * Added option for using single Clangd instance for the whole session @@ -62,6 +64,7 @@ Editing * Added option for indexing priority (`--background-index-priority`) * Added option for maximum number of completion results (default 100) (QTCREATORBUG-27152) + * Added `"`, `<` and `/` to auto-completion triggers (QTCREATORBUG-28203) * Added option for document specific preprocessor directives (QTCREATORBUG-20423) * Fixed semantic highlighting for `__func__` @@ -109,6 +112,7 @@ Projects directory to build directory * Fixed that local environment was used when inspecting GCC toolchain on remote * Fixed stopping terminal process (QTCREATORBUG-28365) +* Fixed automatic popup of `Issues` (QTCREATORBUG-28330) ### CMake @@ -141,11 +145,17 @@ Projects Debugging --------- +### C++ + +* Improved type name lookup performance for heavily templated code +* Improved display performance for large array-like data (QTCREATORBUG-28111) * Added warning for missing QML debugging functionality for mobile and embedded devices * Fixed display of strings with characters more than 2 bytes long -* Improved type name lookup performance for heavily templated code -* Improved display performance for large array-like data (QTCREATORBUG-28111) + +### QML + +* Fixed interrupting Analyzer -------- @@ -155,9 +165,15 @@ Analyzer * Fixed error when analyzing non-desktop targets (QTCREATORBUG-25615) * Fixed wrong failure count display (QTCREATORBUG-27330) +### Perf + +* Fixed wrong working directory (QTCREATORBUG-28462) + Version Control Systems ----------------------- +* Fixed that `--password` argument was shown in plain text (QTCREATORBUG-28413) + ### Git * Added support for user-configured comment character (QTCREATORBUG-28042) @@ -208,6 +224,7 @@ Platforms * Fixed emulator operations when the deprecated `SDK Tools` is installed in addition to `SDK Command-line Tools` (QTCREATORBUG-28196) * Fixed debugging over WiFi (QTCREATORBUG-28342) +* Worked around QML debugging not being enabled by default with NDK 24 and 25 ### iOS @@ -223,6 +240,7 @@ Platforms ### Boot to Qt * Fixed that `rsync` was not available for deployment (QTCREATORBUG-24731) +* Fixed default deployment method ### Docker From dfa5b546476d7b8fcb7792b9fc8bde6282b2b144 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Mon, 21 Nov 2022 15:02:57 +0100 Subject: [PATCH 2/5] Utils: Fix StyleHelper::drawArrow workaround for 6.4.0 The workaround that fixed the drawing of arrows after a change between 6.4.0 and 6.4.1 broke the drawing of arrows with Qt 6.4.0. This change add another enforced detachment of the palette (leading to a modified cache key) that works with Qt 6.4.0. It still works with 6.4.1. Amends: 9d32093421adec260a8abc0920257564d45c12bf Change-Id: I8917c99488cec4fb17ed148bb3b0f95d4ed7127c Reviewed-by: Eike Ziller --- src/libs/utils/stylehelper.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libs/utils/stylehelper.cpp b/src/libs/utils/stylehelper.cpp index ade12533db3..b60a35c33fd 100644 --- a/src/libs/utils/stylehelper.cpp +++ b/src/libs/utils/stylehelper.cpp @@ -306,9 +306,14 @@ void StyleHelper::drawArrow(QStyle::PrimitiveElement element, QPainter *painter, static const QCommonStyle* const style = qobject_cast(QApplication::style()); if (!style) return; + + // Workaround for QTCREATORBUG-28470 QPalette pal = tweakedOption.palette; + pal.setBrush(QPalette::Base, pal.text()); // Base and Text differ, causing a detachment. + // Inspired by tst_QPalette::cacheKey() pal.setColor(QPalette::ButtonText, color.rgb()); - tweakedOption.palette = pal; // Workaround for QTCREATORBUG-28470 + + tweakedOption.palette = pal; tweakedOption.rect = rect; painter.setOpacity(color.alphaF()); style->QCommonStyle::drawPrimitive(element, &tweakedOption, &painter); From 0f8613f61b442ed9f3aa45c55c6c165f1f4779aa Mon Sep 17 00:00:00 2001 From: Marcus Tillmanns Date: Tue, 22 Nov 2022 09:00:11 +0100 Subject: [PATCH 3/5] CPPEditor: Allow clangd from device Change-Id: Ia9b59b374aaebf0bfb820b5a289c6e3c0599cb10 Reviewed-by: Christian Kandeler --- src/plugins/cppeditor/cppcodemodelsettingspage.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/cppeditor/cppcodemodelsettingspage.cpp b/src/plugins/cppeditor/cppcodemodelsettingspage.cpp index 476a3dae5c1..88c877ccbef 100644 --- a/src/plugins/cppeditor/cppcodemodelsettingspage.cpp +++ b/src/plugins/cppeditor/cppcodemodelsettingspage.cpp @@ -217,6 +217,7 @@ ClangdSettingsWidget::ClangdSettingsWidget(const ClangdSettings::Data &settingsD d->useClangdCheckBox.setChecked(settings.useClangd()); d->clangdChooser.setExpectedKind(Utils::PathChooser::ExistingCommand); d->clangdChooser.setFilePath(settings.clangdFilePath()); + d->clangdChooser.setAllowPathFromDevice(true); d->clangdChooser.setEnabled(d->useClangdCheckBox.isChecked()); using Priority = ClangdSettings::IndexingPriority; for (Priority prio : {Priority::Off, Priority::Background, Priority::Low, Priority::Normal}) { From b7716087e12d2c5f0b67d55f84a8a58619bdf900 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Tue, 22 Nov 2022 12:09:16 +0100 Subject: [PATCH 4/5] tst_tracing_*: Fix build in certain configurations There are Linux distributions that (at least for building packages) separate the development packages for the various Qt modules. So, to find the include in timelinemodel.h when building the test, a dependency on QtQml is required. Pass the dependency down to everyone depending on the tracing lib. Fixes: QTCREATORBUG-28434 Change-Id: I58a534a9c25f1f6ecfc10a9ce8292b5983cdcbae Reviewed-by: Christian Stenger Reviewed-by: Qt CI Bot --- src/libs/tracing/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/tracing/CMakeLists.txt b/src/libs/tracing/CMakeLists.txt index 3b8eed445a9..c7f59798198 100644 --- a/src/libs/tracing/CMakeLists.txt +++ b/src/libs/tracing/CMakeLists.txt @@ -38,8 +38,8 @@ find_package(Qt6 COMPONENTS ShaderTools QUIET) add_qtc_library(Tracing CONDITION TARGET Qt6::ShaderTools AND TARGET Qt5::Quick FEATURE_INFO - DEPENDS Utils Qt5::Qml Qt5::Quick - PUBLIC_DEPENDS Qt5::Widgets + DEPENDS Utils Qt5::Quick + PUBLIC_DEPENDS Qt5::Widgets Qt5::Qml SOURCES ${TEST_SOURCES} ) From 373200accf6401f1b5fee7d93e87ab7841c50a6d Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Wed, 23 Nov 2022 11:07:42 +0100 Subject: [PATCH 5/5] Fix double * for long names of changed documents We used to elide the right part of the name, and needed to take care of not eliding the * away in that case. Now we elide in the middle, and in that case the * may not be added to the elided text again. Change-Id: I646b51d315e141a65df67841e163826e7136c118 Reviewed-by: Christian Stenger --- src/plugins/coreplugin/manhattanstyle.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/plugins/coreplugin/manhattanstyle.cpp b/src/plugins/coreplugin/manhattanstyle.cpp index 43b30b65550..2164cd22380 100644 --- a/src/plugins/coreplugin/manhattanstyle.cpp +++ b/src/plugins/coreplugin/manhattanstyle.cpp @@ -874,21 +874,24 @@ void ManhattanStyle::drawControl(ControlElement element, const QStyleOption *opt editRect.adjust(0, 0, -13, 0); } + Qt::TextElideMode elideMode = Qt::ElideRight; + if (widget && widget->dynamicPropertyNames().contains("elidemode")) + elideMode = widget->property("elidemode").value(); + QLatin1Char asterisk('*'); int elideWidth = editRect.width(); - bool notElideAsterisk = widget && widget->property("notelideasterisk").toBool() + bool notElideAsterisk = elideMode == Qt::ElideRight && widget + && widget->property("notelideasterisk").toBool() && cb->currentText.endsWith(asterisk) - && option->fontMetrics.horizontalAdvance(cb->currentText) > elideWidth; + && option->fontMetrics.horizontalAdvance(cb->currentText) + > elideWidth; QString text; if (notElideAsterisk) { elideWidth -= option->fontMetrics.horizontalAdvance(asterisk); text = asterisk; } - Qt::TextElideMode elideMode = Qt::ElideRight; - if (widget && widget->dynamicPropertyNames().contains("elidemode")) - elideMode = widget->property("elidemode").value(); text.prepend(option->fontMetrics.elidedText(cb->currentText, elideMode, elideWidth)); if (creatorTheme()->flag(Theme::ComboBoxDrawTextShadow)