feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning: "Don't call QHash::operator[]() on temporary"

Browse Source 
[-Wclazy-detaching-temporary]

Change-Id: Ide503c9260af285fa1dbedb63f7819c8ad616db6
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Alessandro Portale
2019-01-17 02:09:05 +01:00
parent 504123cba5
commit adea8467f4
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/scxmleditor/plugin_interface/sceneutils.cpp
View File

@@ -221,7 +221,7 @@ void layout(const QList<QGraphicsItem*> &items)
// Change initial-item position
ConnectableItem *firstItem = nullptr;
if (initialItem && initialItem->outputTransitionCount() == 1) {
firstItem = initialItem->outputTransitions()[0]->connectedItem(initialItem);
firstItem = initialItem->outputTransitions().constFirst()->connectedItem(initialItem);
int index = childItems.indexOf(firstItem);
if (index > 0)
childItems.swap(index, 0);
@@ -230,7 +230,7 @@ void layout(const QList<QGraphicsItem*> &items)
// Search final-item
ConnectableItem *lastItem = nullptr;
if (finalItem && finalItem->inputTransitionCount() > 0)
lastItem = finalItem->inputTransitions()[0]->connectedItem(finalItem);
lastItem = finalItem->inputTransitions().constFirst()->connectedItem(finalItem);
int startAngle = qrand() % 2 == 0 ? 180 : 90;
int startDistance = 40 + childItems.count() * 10;