feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: De-virtualize some more virtual methods

Browse Source 
Use setters/getters for the bool flags in
Project::needsBuildConfigurations() and
Project::hasMakeInstallEquivalent.

Change-Id: I5ce937c3a5e8e0db627cda02a9007f8c28ccda0c
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2019-08-13 12:11:07 +02:00
parent afb4fb474f
commit ae345003aa
12 changed files with 30 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/projectexplorer/project.cpp
View File

@@ -167,6 +167,8 @@ public:
bool m_needsInitialExpansion = false;
bool m_canBuildProducts = false;
bool m_knowsAllBuildExecutables = true;
bool m_hasMakeInstallEquivalent = false;
bool m_needsBuildConfigurations = true;
std::unique_ptr<Core::IDocument> m_document;
std::unique_ptr<ProjectNode> m_rootProjectNode;
std::unique_ptr<ContainerNode> m_containerNode;
@@ -809,6 +811,11 @@ void Project::setProjectLanguage(Core::Id id, bool enabled)
removeProjectLanguage(id);
}
void Project::setHasMakeInstallEquivalent(bool enabled)
{
d->m_hasMakeInstallEquivalent = enabled;
}
void Project::projectLoaded()
{
}
@@ -818,6 +825,11 @@ void Project::setKnowsAllBuildExecutables(bool value)
d->m_knowsAllBuildExecutables = value;
}
void Project::setNeedsBuildConfigurations(bool value)
{
d->m_needsBuildConfigurations = value;
}
Task Project::createProjectTask(Task::TaskType type, const QString &description)
{
return Task(type, description, Utils::FilePath(), -1, Core::Id());
@@ -861,7 +873,7 @@ bool Project::needsConfiguration() const
bool Project::needsBuildConfigurations() const
{
return true;
return d->m_needsBuildConfigurations;
}
void Project::configureAsExampleProject()
@@ -873,6 +885,11 @@ bool Project::knowsAllBuildExecutables() const
return d->m_knowsAllBuildExecutables;
}
bool Project::hasMakeInstallEquivalent() const
{
return d->m_hasMakeInstallEquivalent;
}
MakeInstallCommand Project::makeInstallCommand(const Target *target, const QString &installRoot)
{
QTC_ASSERT(hasMakeInstallEquivalent(), return MakeInstallCommand());