forked from qt-creator/qt-creator
Clang: Return ClangString instead of Utf8String
Utf8String is allocating memory but for many compares it is not needed. In an inner loop this can be expensive. Change-Id: I6320823ab7e086008447eea255e52859a7faaad7 Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io> Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
@@ -167,4 +167,31 @@ TEST(ClangString, EqualCStringAndClangStringPointer)
|
||||
ASSERT_TRUE(textIsEqual);
|
||||
}
|
||||
|
||||
TEST(ClangString, NullStringHasNoContent)
|
||||
{
|
||||
ClangString text(CXString{nullptr, 0});
|
||||
|
||||
bool hasContent = text.hasContent();
|
||||
|
||||
ASSERT_FALSE(hasContent);
|
||||
}
|
||||
|
||||
TEST(ClangString, EmptyStringHasNoContent)
|
||||
{
|
||||
ClangString text(CXString{"", 0});
|
||||
|
||||
bool hasContent = text.hasContent();
|
||||
|
||||
ASSERT_FALSE(hasContent);
|
||||
}
|
||||
|
||||
TEST(ClangString, StringHasNoContent)
|
||||
{
|
||||
ClangString text(CXString{"text", 0});
|
||||
|
||||
bool hasContent = text.hasContent();
|
||||
|
||||
ASSERT_TRUE(hasContent);
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user