feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsManager: Avoid using sender()

Browse Source 
Change-Id: I09cca9c85b4300f25aa195be3c399d1511e2da11
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2022-07-19 19:09:23 +02:00
parent e7b43b6b8b
commit ae9a330344
2 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/coreplugin/vcsmanager.cpp
View File

@@ -173,17 +173,18 @@ VcsManager *VcsManager::instance()
void VcsManager::extensionsInitialized() void VcsManager::extensionsInitialized()
{ {
// Change signal connections // Change signal connections
const QList<IVersionControl *> versionControlList = versionControls(); const QList<IVersionControl *> vcs = versionControls();
for (const IVersionControl *versionControl : versionControlList) { for (IVersionControl *vc : vcs) {
connect(versionControl, &IVersionControl::filesChanged, DocumentManager::instance(), connect(vc, &IVersionControl::filesChanged, DocumentManager::instance(),
[](const QStringList fileNames) { [](const QStringList &fileNames) {
DocumentManager::notifyFilesChangedInternally( DocumentManager::notifyFilesChangedInternally(
Utils::transform(fileNames, &Utils::FilePath::fromString)); Utils::transform(fileNames, &Utils::FilePath::fromString));
}); });
connect(versionControl, &IVersionControl::repositoryChanged, connect(vc, &IVersionControl::repositoryChanged,
m_instance, &VcsManager::repositoryChanged); m_instance, &VcsManager::repositoryChanged);
connect(versionControl, &IVersionControl::configurationChanged, connect(vc, &IVersionControl::configurationChanged, m_instance, [vc] {
m_instance, &VcsManager::handleConfigurationChanges); m_instance->handleConfigurationChanges(vc);
});
} }
} }
@@ -474,12 +475,10 @@ void VcsManager::clearVersionControlCache()
emit m_instance->repositoryChanged(FilePath::fromString(repo)); emit m_instance->repositoryChanged(FilePath::fromString(repo));
} }
void VcsManager::handleConfigurationChanges() void VcsManager::handleConfigurationChanges(IVersionControl *vc)
{ {
d->m_cachedAdditionalToolsPathsDirty = true; d->m_cachedAdditionalToolsPathsDirty = true;
auto vcs = qobject_cast<IVersionControl *>(sender()); emit configurationChanged(vc);
if (vcs)
emit configurationChanged(vcs);
} }
} // namespace Core } // namespace Core

2
src/plugins/coreplugin/vcsmanager.h
View File

@@ -106,7 +106,7 @@ private:
explicit VcsManager(QObject *parent = nullptr); explicit VcsManager(QObject *parent = nullptr);
~VcsManager() override; ~VcsManager() override;
void handleConfigurationChanges(); void handleConfigurationChanges(IVersionControl *vc);
static void addVersionControl(IVersionControl *vc); static void addVersionControl(IVersionControl *vc);
friend class Core::Internal::MainWindow; friend class Core::Internal::MainWindow;