Core: Remove #include <QMainWindow> from icore.h

Adapt users; also use dialogParent() instead of mainWindow() were
appropriate.

Change-Id: Ib60b118f05c986a70657446c5b2937074243bb5c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>

src/plugins/android/androidavdmanager.cpp

@@ -39,6 +39,7 @@
 #include <QApplication>
 #include <QFileInfo>
 #include <QLoggingCategory>
+#include <QMainWindow>
 #include <QMessageBox>
 #include <QSettings>
 

src/plugins/clangcodemodel/clangtextmark.cpp

@@ -47,6 +47,7 @@
 
 #include <QAction>
 #include <QLayout>
+#include <QMainWindow>
 #include <QRegularExpression>
 #include <QRegularExpressionMatch>
 #include <QString>

src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp

@@ -412,14 +412,14 @@ bool CMakeBuildSystem::mustApplyConfigurationChangesArguments(const BuildDirPara
     if (parameters.configurationChangesArguments.isEmpty())
         return false;
 
-    auto answer = QMessageBox::question(Core::ICore::mainWindow(),
+    int answer = QMessageBox::question(Core::ICore::dialogParent(),
-                                        tr("Apply configuration changes?"),
+                                       tr("Apply configuration changes?"),
-                                        "<p>" + tr("Run CMake with configuration changes?")
+                                       "<p>" + tr("Run CMake with configuration changes?")
-                                            + "</p><pre>"
+                                       + "</p><pre>"
-                                            + parameters.configurationChangesArguments.join("\n")
+                                       + parameters.configurationChangesArguments.join("\n")
-                                            + "</pre>",
+                                       + "</pre>",
-                                        QMessageBox::Apply | QMessageBox::Discard,
+                                       QMessageBox::Apply | QMessageBox::Discard,
-                                        QMessageBox::Apply);
+                                       QMessageBox::Apply);
     return answer == QMessageBox::Apply;
 }
 

src/plugins/coreplugin/actionmanager/actionmanager.cpp

@@ -37,6 +37,7 @@
 #include <QAction>
 #include <QApplication>
 #include <QDebug>
+#include <QMainWindow>
 #include <QMenu>
 #include <QMenuBar>
 #include <QSettings>

src/plugins/coreplugin/editormanager/editormanager.cpp

@@ -94,6 +94,7 @@
 #include <QAction>
 #include <QApplication>
 #include <QFileDialog>
+#include <QMainWindow>
 #include <QMenu>
 #include <QMessageBox>
 #include <QPushButton>

src/plugins/coreplugin/icore.h

@@ -32,7 +32,6 @@
 #include <utils/qtcsettings.h>
 
 #include <QList>
-#include <QMainWindow>
 #include <QObject>
 #include <QRect>
 #include <QSettings>
@@ -40,6 +39,7 @@
 #include <functional>
 
 QT_BEGIN_NAMESPACE
+class QMainWindow;
 class QPrinter;
 class QStatusBar;
 class QWidget;

src/plugins/coreplugin/locator/locator.cpp

@@ -58,6 +58,7 @@
 #include <utils/utilsicons.h>
 
 #include <QAction>
+#include <QMainWindow>
 #include <QSettings>
 
 using namespace Utils;

src/plugins/coreplugin/loggingviewer.cpp

@@ -732,7 +732,7 @@ void LoggingViewManagerWidget::setCategoryColor(const QString &category, const Q
 void LoggingViewer::showLoggingView()
 {
     ActionManager::command(Constants::LOGGER)->action()->setEnabled(false);
-    auto widget = new LoggingViewManagerWidget(ICore::mainWindow());
+    auto widget = new LoggingViewManagerWidget(ICore::dialogParent());
     QObject::connect(widget, &QDialog::finished, widget, [widget] () {
         ActionManager::command(Constants::LOGGER)->action()->setEnabled(true);
         // explicitly disable manager again

src/plugins/projectexplorer/miniprojecttargetselector.cpp

@@ -60,6 +60,7 @@
 #include <QLayout>
 #include <QList>
 #include <QListWidget>
+#include <QMainWindow>
 #include <QPainter>
 #include <QPixmap>
 #include <QStatusBar>

src/plugins/qmldesigner/assetexporterplugin/assetexportdialog.cpp

@@ -91,7 +91,7 @@ AssetExportDialog::AssetExportDialog(const Utils::FilePath &exportPath,
     m_ui->exportPath->setPromptDialogFilter(tr("Metadata file (*.metadata)"));
     m_ui->exportPath->lineEdit()->setReadOnly(true);
     m_ui->exportPath->addButton(tr("Open"), this, [this]() {
-        Core::FileUtils::showInGraphicalShell(Core::ICore::mainWindow(), m_ui->exportPath->filePath());
+        Core::FileUtils::showInGraphicalShell(Core::ICore::dialogParent(), m_ui->exportPath->filePath());
     });
 
     auto optionsWidget = new QWidget;

src/plugins/qmldesigner/components/componentcore/designeractionmanager.cpp

@@ -525,21 +525,21 @@ public:
 
         model.setListView(targetNode);
 
-        ListModelEditorDialog dialog{Core::ICore::mainWindow()};
+        ListModelEditorDialog dialog{Core::ICore::dialogParent()};
         dialog.setModel(&model);
 
         try {
             dialog.exec();
         } catch (const DocumentError &) {
             QMessageBox::warning(
-                Core::ICore::mainWindow(),
+                Core::ICore::dialogParent(),
                 QCoreApplication::translate("DesignerActionManager", "Document Has Errors"),
                 QCoreApplication::translate("DesignerActionManager",
                                             "The document which contains the list model "
                                             "contains errors. So we cannot edit it."));
         } catch (const RewritingException &) {
             QMessageBox::warning(
-                Core::ICore::mainWindow(),
+                Core::ICore::dialogParent(),
                 QCoreApplication::translate("DesignerActionManager", "Document Cannot Be Written"),
                 QCoreApplication::translate("DesignerActionManager",
                                             "An error occurred during a write attemp."));

src/plugins/qmldesigner/components/itemlibrary/itemlibraryassetimportdialog.cpp

@@ -373,7 +373,7 @@ void ItemLibraryAssetImportDialog::updateImport(const ModelNode &updateNode,
                                         {sourceInfo.absoluteFilePath()},
                                         node.model()->fileUrl().toLocalFile(),
                                         supportedExts, supportedOpts, options,
-                                        preselectedFiles, Core::ICore::mainWindow());
+                                        preselectedFiles, Core::ICore::dialogParent());
                             importDlg->show();
 
                         } else {

src/plugins/qmldesigner/components/itemlibrary/itemlibraryview.cpp

@@ -169,7 +169,7 @@ void ItemLibraryView::updateImport3DSupport(const QVariantMap &supportMap)
             auto importDlg = new ItemLibraryAssetImportDialog(fileNames, defaultDir,
                                                               m_importableExtensions3DMap,
                                                               m_importOptions3DMap, {}, {},
-                                                              Core::ICore::mainWindow());
+                                                              Core::ICore::dialogParent());
             int result = importDlg->exec();
 
             return result == QDialog::Accepted ? AddFilesResult::Succeeded : AddFilesResult::Cancelled;

src/plugins/qmldesigner/components/listmodeleditor/listmodeleditordialog.cpp

@@ -37,6 +37,7 @@
 #include <QInputDialog>
 #include <QKeyEvent>
 #include <QLineEdit>
+#include <QMainWindow>
 #include <QTableView>
 #include <QToolBar>
 #include <QVBoxLayout>

src/plugins/welcome/welcomeplugin.cpp

@@ -147,7 +147,7 @@ public:
 
         auto introAction = new QAction(tr("UI Tour"), this);
         connect(introAction, &QAction::triggered, this, []() {
-            auto intro = new IntroductionWidget(ICore::mainWindow());
+            auto intro = new IntroductionWidget(ICore::dialogParent());
             intro->show();
         });
         Command *cmd = ActionManager::registerAction(introAction, "Welcome.UITour");
@@ -157,7 +157,7 @@ public:
 
         if (!arguments.contains("-notour")) {
             connect(ICore::instance(), &ICore::coreOpened, this, []() {
-                IntroductionWidget::askUserAboutIntroduction(ICore::mainWindow(),
+                IntroductionWidget::askUserAboutIntroduction(ICore::dialogParent(),
                                                              ICore::settings());
             }, Qt::QueuedConnection);
         }