feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: clang-tidy fix for 'move-const-arg'

Browse Source 
See https://releases.llvm.org/17.0.1/tools/clang/tools/extra/docs/clang-
tidy/checks/performance/move-const-arg.html

Change-Id: Ic20445321286fdcb8b02e1b2cf170e0fe60fd1fd
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Cristian Adam
2023-10-20 15:05:12 +02:00
parent 55cccfa59e
commit aef415a25d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/fileapiparser.cpp
View File

@@ -874,11 +874,11 @@ FileApiData FileApiParser::parseData(QPromise<std::shared_ptr<FileApiQtcData>> &
return result; return result;
} }
auto it = std::find_if(codeModels.cbegin(), codeModels.cend(), auto it = std::find_if(codeModels.begin(), codeModels.end(),
[cmakeBuildType](const Configuration& cfg) { [cmakeBuildType](const Configuration& cfg) {
return QString::compare(cfg.name, cmakeBuildType, Qt::CaseInsensitive) == 0; return QString::compare(cfg.name, cmakeBuildType, Qt::CaseInsensitive) == 0;
}); });
if (it == codeModels.cend()) { if (it == codeModels.end()) {
QStringList buildTypes; QStringList buildTypes;
for (const Configuration &cfg: codeModels) for (const Configuration &cfg: codeModels)
buildTypes << cfg.name; buildTypes << cfg.name;

4
src/plugins/cmakeprojectmanager/fileapireader.cpp
View File

@@ -285,8 +285,8 @@ void FileApiReader::endState(const FilePath &replyFilePath, bool restoredFromBac
m_projectParts = std::move(value->projectParts); m_projectParts = std::move(value->projectParts);
m_rootProjectNode = std::move(value->rootProjectNode); m_rootProjectNode = std::move(value->rootProjectNode);
m_ctestPath = std::move(value->ctestPath); m_ctestPath = std::move(value->ctestPath);
m_isMultiConfig = std::move(value->isMultiConfig); m_isMultiConfig = value->isMultiConfig;
m_usesAllCapsTargets = std::move(value->usesAllCapsTargets); m_usesAllCapsTargets = value->usesAllCapsTargets;
if (value->errorMessage.isEmpty()) { if (value->errorMessage.isEmpty()) {
emit this->dataAvailable(restoredFromBackup); emit this->dataAvailable(restoredFromBackup);