feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Hard-code version dependency of m_dissembleUsesComma

Browse Source 
We don't support GDB in the range 7.0...7.3 anymore where the
outcome was unsure.

Change-Id: I1ce76f5c4b1febe45c4a3b6404208fed7d9c6868
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
hjk
2013-05-28 11:52:41 +02:00
parent 91ba674db4
commit af69f732f1
2 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -1813,6 +1813,9 @@ void GdbEngine::handleShowVersion(const GdbResponse &response)
if (m_gdbVersion > 70300)
m_hasBreakpointNotifications = true;
if (m_gdbVersion > 70100)
m_disassembleUsesComma = true;
if (usesExecInterrupt())
postCommand("set target-async on", ConsoleCommand);
else
@@ -4641,11 +4644,6 @@ void GdbEngine::reloadDisassembly()
updateLocals();
}
void GdbEngine::handleDisassemblerCheck(const GdbResponse &response)
{
m_disassembleUsesComma = response.resultClass != GdbResultDone;
}
void GdbEngine::handleFetchDisassemblerByCliPointMixed(const GdbResponse &response)
{
DisassemblerAgentCookie ac = response.cookie.value<DisassemblerAgentCookie>();
@@ -4851,10 +4849,6 @@ void GdbEngine::startGdb(const QStringList &args)
postCommand("set remotecache on", ConsoleCommand);
//postCommand("set non-stop on", ConsoleCommand);
showMessage(_("THE FOLLOWING COMMAND CHECKS AVAILABLE FEATURES. "
"AN ERROR IS EXPECTED."));
postCommand("disassemble 0 0", ConsoleCommand, CB(handleDisassemblerCheck));
typedef GlobalDebuggerOptions::SourcePathMap SourcePathMap;
typedef SourcePathMap::const_iterator SourcePathMapIterator;