From af712dc0e7e74fa4542aac37844360edb8d33ee2 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 27 Feb 2024 15:34:32 +0100
Subject: [PATCH] Axivion: Fix clazy warning about mixing const and mutable
 iterators

Change-Id: Ief898ff2febb958f3f68a64ddcb614479854600f
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Andreas Loth <andreas.loth@qt.io>
---
 src/plugins/axivion/axivionplugin.cpp | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/plugins/axivion/axivionplugin.cpp b/src/plugins/axivion/axivionplugin.cpp
index 6e04af7e30d..43316c4f8b7 100644
--- a/src/plugins/axivion/axivionplugin.cpp
+++ b/src/plugins/axivion/axivionplugin.cpp
@@ -69,14 +69,15 @@ QIcon iconForIssue(const std::optional<Dto::IssueKind> &issueKind)
         return {};
 
     static QHash<Dto::IssueKind, QIcon> prefixToIcon;
+
     auto it = prefixToIcon.constFind(*issueKind);
-    if (it == prefixToIcon.constEnd()) {
-        const auto prefix = Dto::IssueKindMeta::enumToStr(*issueKind);
-        const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"),
-                          Theme::PaletteButtonText}}, Icon::Tint);
-        it = prefixToIcon.insert(*issueKind, icon.icon());
-    }
-    return it.value();
+    if (it != prefixToIcon.constEnd())
+        return *it;
+
+    const QLatin1String prefix = Dto::IssueKindMeta::enumToStr(*issueKind);
+    const Icon icon({{FilePath::fromString(":/axivion/images/button-" + prefix + ".png"),
+                      Theme::PaletteButtonText}}, Icon::Tint);
+    return prefixToIcon.insert(*issueKind, icon.icon()).value();
 }
 
 QString anyToSimpleString(const Dto::Any &any)