feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Process: Get rid of setTimeoutS()

Browse Source 
Add an extra arg to runBlocking() function instead.
Use std::chrono::seconds for timeout.

Change-Id: I7c3c21e8f26a2ccbed157d15083d6ef0b4cd2f7e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2024-01-22 17:27:24 +01:00
parent f6be85b1d2
commit afc67468e6
33 changed files with 68 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/libs/utils/pathchooser.cpp
View File

@@ -133,9 +133,8 @@ QString BinaryVersionToolTipEventFilter::toolVersion(const CommandLine &cmd)
if (cmd.executable().isEmpty())
return QString();
Process proc;
proc.setTimeoutS(1);
proc.setCommand(cmd);
proc.runBlocking();
proc.runBlocking(std::chrono::seconds(1));
if (proc.result() != ProcessResult::FinishedWithSuccess)
return QString();
return proc.allOutput();