feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Do not use native separators at all

Browse Source 
Since valgrind only runs on POSIX systems, all the paths it produces are
normalized.

We have no mapping to local directory, so having a path like
\home\user\project\file.cpp is confusing.

Change-Id: Idff339729231ab662aa4fcb6bb732058c1a04f7c
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2015-02-02 10:50:48 +02:00
committed by hjk
parent 4e8e75d88e
commit b001e54599
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/valgrind/memcheckerrorview.cpp
View File

@@ -109,7 +109,9 @@ static QString makeFrameName(const Frame &frame, const QString &relativeTo,
if (frame.line() != -1) if (frame.line() != -1)
path += QLatin1Char(':') + QString::number(frame.line()); path += QLatin1Char(':') + QString::number(frame.line());
path = QDir::toNativeSeparators(path.toHtmlEscaped()); // Since valgrind only runs on POSIX systems, converting path separators
// will ruin the paths on Windows. Leave it untouched.
path = path.toHtmlEscaped();
if (link && !f.isEmpty() && QFile::exists(fullPath)) { if (link && !f.isEmpty() && QFile::exists(fullPath)) {
// make a hyperlink label // make a hyperlink label