feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Use functor for apply in CommonSettingsWidget

Browse Source 
More compact.

Change-Id: Ib5985b9aa6fb9fcbe9ff1fffdc17c6c0888f786e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2023-05-08 13:06:14 +02:00
parent 06b0d105dc
commit b03808031a
1 changed files with 35 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

83
src/plugins/vcsbase/commonvcssettings.cpp
View File

@@ -94,61 +94,48 @@ CommonVcsSettings::CommonVcsSettings()
class CommonSettingsWidget final : public Core::IOptionsPageWidget
{
public:
CommonSettingsWidget(CommonOptionsPage *page);
CommonSettingsWidget(CommonOptionsPage *page)
{
CommonVcsSettings &s = page->settings();
void apply() final;
auto cacheResetButton = new QPushButton(Tr::tr("Reset VCS Cache"));
cacheResetButton->setToolTip(Tr::tr("Reset information about which "
"version control system handles which directory."));
private:
void updatePath();
CommonOptionsPage *m_page;
};
auto updatePath = [&s] {
Environment env;
env.appendToPath(Core::VcsManager::additionalToolsPath());
s.sshPasswordPrompt.setEnvironment(env);
};
using namespace Layouting;
Column {
Row { s.lineWrap, s.lineWrapWidth, st },
Form {
s.submitMessageCheckScript, br,
s.nickNameMailMap, br,
s.nickNameFieldListFile, br,
s.sshPasswordPrompt, br,
{}, cacheResetButton
}
}.attachTo(this);
CommonSettingsWidget::CommonSettingsWidget(CommonOptionsPage *page)
: m_page(page)
{
CommonVcsSettings &s = m_page->settings();
updatePath();
auto cacheResetButton = new QPushButton(Tr::tr("Reset VCS Cache"));
cacheResetButton->setToolTip(Tr::tr("Reset information about which "
"version control system handles which directory."));
connect(Core::VcsManager::instance(), &Core::VcsManager::configurationChanged,
this, updatePath);
connect(cacheResetButton, &QPushButton::clicked,
Core::VcsManager::instance(), &Core::VcsManager::clearVersionControlCache);
updatePath();
using namespace Layouting;
Column {
Row { s.lineWrap, s.lineWrapWidth, st },
Form {
s.submitMessageCheckScript, br,
s.nickNameMailMap, br,
s.nickNameFieldListFile, br,
s.sshPasswordPrompt, br,
{}, cacheResetButton
}
}.attachTo(this);
connect(Core::VcsManager::instance(), &Core::VcsManager::configurationChanged,
this, &CommonSettingsWidget::updatePath);
connect(cacheResetButton, &QPushButton::clicked,
Core::VcsManager::instance(), &Core::VcsManager::clearVersionControlCache);
}
void CommonSettingsWidget::updatePath()
{
Environment env;
env.appendToPath(Core::VcsManager::additionalToolsPath());
m_page->settings().sshPasswordPrompt.setEnvironment(env);
}
void CommonSettingsWidget::apply()
{
CommonVcsSettings &s = m_page->settings();
if (s.isDirty()) {
s.apply();
s.writeSettings(Core::ICore::settings());
emit m_page->settingsChanged();
setOnApply([&s, page] {
if (s.isDirty()) {
s.apply();
s.writeSettings(Core::ICore::settings());
emit page->settingsChanged();
}
});
}
}
};
// CommonOptionsPage