From b054e1b1f5b43c71a2557cc979e704cc6bdaeea7 Mon Sep 17 00:00:00 2001 From: Robert Loehning Date: Tue, 12 Dec 2017 14:15:53 +0100 Subject: [PATCH] BuildConfiguration: Check return value of fromMap Change-Id: I18edefc20ff962720f36192121e3f6e341b1bcbc Reviewed-by: Tobias Hunger --- src/plugins/projectexplorer/buildconfiguration.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/projectexplorer/buildconfiguration.cpp b/src/plugins/projectexplorer/buildconfiguration.cpp index b1556595de5..50866d63a42 100644 --- a/src/plugins/projectexplorer/buildconfiguration.cpp +++ b/src/plugins/projectexplorer/buildconfiguration.cpp @@ -487,7 +487,10 @@ BuildConfiguration *IBuildConfigurationFactory::clone(Target *parent, BuildConfi return nullptr; BuildConfiguration *bc = m_creator(parent); QVariantMap data = product->toMap(); - bc->fromMap(data); + if (!bc->fromMap(data)) { + delete bc; + bc = nullptr; + } return bc; }