From b085091526db64587e646a9e6762440636bdefd6 Mon Sep 17 00:00:00 2001 From: Assam Boudjelthia Date: Tue, 30 Jun 2020 16:07:09 +0300 Subject: [PATCH] Android: handle some TODO comments Change-Id: Id1848dccc0a9b43ed77c0bd99329a0b81705a17a Reviewed-by: Alessandro Portale --- src/plugins/android/androiddeployqtstep.cpp | 6 +++++- src/plugins/android/androidpotentialkit.h | 2 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/plugins/android/androiddeployqtstep.cpp b/src/plugins/android/androiddeployqtstep.cpp index d5ebc691554..176c8ebf7ba 100644 --- a/src/plugins/android/androiddeployqtstep.cpp +++ b/src/plugins/android/androiddeployqtstep.cpp @@ -163,8 +163,12 @@ Core::Id AndroidDeployQtStep::stepId() bool AndroidDeployQtStep::init() { QtSupport::BaseQtVersion *version = QtSupport::QtKitAspect::qtVersion(target()->kit()); - if (!version) // TODO: Add error message + if (!version) { + qCDebug(deployStepLog, + "The Qt version for kit %s is not valid.", + qPrintable(target()->kit()->displayName())); return false; + } m_androiddeployqtArgs = CommandLine(); diff --git a/src/plugins/android/androidpotentialkit.h b/src/plugins/android/androidpotentialkit.h index b7b2e6a3fdc..0bc3f99f69e 100644 --- a/src/plugins/android/androidpotentialkit.h +++ b/src/plugins/android/androidpotentialkit.h @@ -51,7 +51,5 @@ private: void recheck(); }; -// TODO add "Download" links to the settings page? - } }