diff --git a/cmake/QtcSeparateDebugInfo.cmake b/cmake/QtcSeparateDebugInfo.cmake index 768e2974612..9fb4047223a 100644 --- a/cmake/QtcSeparateDebugInfo.cmake +++ b/cmake/QtcSeparateDebugInfo.cmake @@ -26,7 +26,9 @@ function(qtc_enable_separate_debug_info target installDestination) unset(commands) if(APPLE) - find_program(DSYMUTIL_PROGRAM dsymutil) + find_program(DSYMUTIL_PROGRAM dsymutil + NO_PACKAGE_ROOT_PATH + NO_CMAKE_PATH) set(copy_bin ${DSYMUTIL_PROGRAM}) set(strip_bin ${CMAKE_STRIP}) set(debug_info_suffix dSYM) diff --git a/coin/instructions/common_environment.yaml b/coin/instructions/common_environment.yaml index 1208997f8f2..0fb670ae84f 100644 --- a/coin/instructions/common_environment.yaml +++ b/coin/instructions/common_environment.yaml @@ -7,7 +7,7 @@ instructions: variableValue: "RelWithDebInfo" - type: EnvironmentVariable variableName: QTC_QT_BASE_URL - variableValue: "http://ci-files02-hki.intra.qt.io/packages/jenkins/archive/qt/6.2/6.2.0-beta2-released/" + variableValue: "http://ci-files02-hki.intra.qt.io/packages/jenkins/archive/qt/6.2/6.2.0-beta3-released/" - type: EnvironmentVariable variableName: QTC_QT_MODULES variableValue: "qt5compat qtbase qtdeclarative qtimageformats qtquick3d qtquickcontrols2 qtquicktimeline qtserialport qtshadertools qtsvg qttools qttranslations" diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp index 5177c34b5ab..384f6405e5b 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.cpp @@ -814,10 +814,6 @@ void Qt5InformationNodeInstanceServer::doRender3DEditView() m_editView3DData.window->afterRendering(); } #else - if (m_render2D) { - // Render 2D content, as it might be used by 3D content - m_render2D = !renderWindow(); - } renderImage = grabRenderControl(m_editView3DData); #endif @@ -1822,11 +1818,6 @@ void Qt5InformationNodeInstanceServer::changePropertyValues(const ChangeValuesCo if (!container.isReflected()) { hasDynamicProperties |= container.isDynamic(); setInstancePropertyVariant(container); - if (!m_render2D && isQuick3DMode() && hasInstanceForId(container.instanceId())) { - ServerNodeInstance instance = instanceForId(container.instanceId()); - if (instance.isSubclassOf("QQuickItem")) - m_render2D = true; - } } } @@ -1937,17 +1928,6 @@ void Qt5InformationNodeInstanceServer::changeAuxiliaryValues(const ChangeAuxilia void Qt5InformationNodeInstanceServer::changePropertyBindings(const ChangeBindingsCommand &command) { Qt5NodeInstanceServer::changePropertyBindings(command); - - const QVector &values = command.bindingChanges; - for (const PropertyBindingContainer &container : values) { - if (!m_render2D && isQuick3DMode() && hasInstanceForId(container.instanceId())) { - ServerNodeInstance instance = instanceForId(container.instanceId()); - if (instance.isSubclassOf("QQuickItem")) { - m_render2D = true; - break; - } - } - } render3DEditView(); } diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h index fbe13c54da9..ed4f97d81be 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/qt5informationnodeinstanceserver.h @@ -165,7 +165,6 @@ private: QList m_pendingInputEventCommands; QObject *m_3dHelper = nullptr; int m_need3DEditViewRender = 0; - bool m_render2D = true; }; } // namespace QmlDesigner diff --git a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/servernodeinstance.cpp b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/servernodeinstance.cpp index f53e31b49f2..51e4ef2ff5f 100644 --- a/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/servernodeinstance.cpp +++ b/share/qtcreator/qml/qmlpuppet/qml2puppet/instances/servernodeinstance.cpp @@ -219,6 +219,13 @@ QString static getErrorString(QQmlEngine *engine, const QString &componentPath) return s; } +bool isInPathList(const QStringList &pathList, const QString &componentPath) +{ + return std::any_of(pathList.begin(), pathList.end(), [&](auto &&path) { + return componentPath.startsWith(path); + }); +} + ServerNodeInstance ServerNodeInstance::create(NodeInstanceServer *nodeInstanceServer, const InstanceContainer &instanceContainer, ComponentWrap componentWrap) @@ -233,7 +240,9 @@ ServerNodeInstance ServerNodeInstance::create(NodeInstanceServer *nodeInstanceSe object = Internal::ObjectNodeInstance::createCustomParserObject(instanceContainer.nodeSource(), nodeInstanceServer->importCode(), nodeInstanceServer->context()); if (object == nullptr) nodeInstanceServer->sendDebugOutput(DebugOutputCommand::ErrorType, QLatin1String("Custom parser object could not be created."), instanceContainer.instanceId()); - } else if (!instanceContainer.componentPath().isEmpty()) { + } else if (!instanceContainer.componentPath().isEmpty() + && !isInPathList(nodeInstanceServer->engine()->importPathList(), + instanceContainer.componentPath())) { object = Internal::ObjectNodeInstance::createComponent(instanceContainer.componentPath(), nodeInstanceServer->context()); if (object == nullptr) { object = Internal::ObjectNodeInstance::createPrimitive(QString::fromUtf8(instanceContainer.type()), instanceContainer.majorNumber(), instanceContainer.minorNumber(), nodeInstanceServer->context()); diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBox.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBox.qml index 534ef22591d..c5919d2ef27 100644 --- a/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBox.qml +++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBox.qml @@ -258,7 +258,7 @@ T.ComboBox { }, State { name: "edit" - when: myComboBox.enabled && myComboBox.edit && myComboBox.editable && !myComboBox.open + when: myComboBox.enabled && myComboBox.edit && !myComboBox.open PropertyChanges { target: myComboBox wheelEnabled: true diff --git a/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBoxInput.qml b/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBoxInput.qml index 663e7993f1e..6d926b034cb 100644 --- a/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBoxInput.qml +++ b/share/qtcreator/qmldesigner/propertyEditorQmlSources/imports/StudioControls/ComboBoxInput.qml @@ -64,11 +64,15 @@ TextInput { border.width: 0 } - TapHandler { - id: tapHandler - acceptedDevices: PointerDevice.Mouse + MouseArea { + id: mouseArea + anchors.fill: parent enabled: true - onTapped: { + hoverEnabled: true + propagateComposedEvents: true + acceptedButtons: Qt.LeftButton + cursorShape: Qt.PointingHandCursor + onPressed: function(mouse) { if (textInput.readOnly) { if (myControl.popup.opened) { myControl.popup.close() @@ -80,18 +84,9 @@ TextInput { } else { textInput.forceActiveFocus() } - } - } - MouseArea { - id: mouseArea - anchors.fill: parent - enabled: true - hoverEnabled: true - propagateComposedEvents: true - acceptedButtons: Qt.LeftButton - cursorShape: Qt.PointingHandCursor - onPressed: function(mouse) { mouse.accepted = false } + mouse.accepted = false + } } states: [ @@ -103,13 +98,10 @@ TextInput { target: textInputBackground color: StudioTheme.Values.themeControlBackground } - PropertyChanges { - target: tapHandler - enabled: true - } PropertyChanges { target: mouseArea cursorShape: Qt.PointingHandCursor + acceptedButtons: Qt.LeftButton } }, State { @@ -145,13 +137,10 @@ TextInput { target: textInputBackground color: StudioTheme.Values.themeControlBackgroundInteraction } - PropertyChanges { - target: tapHandler - enabled: false - } PropertyChanges { target: mouseArea cursorShape: Qt.IBeamCursor + acceptedButtons: Qt.NoButton } }, State { diff --git a/share/qtcreator/styles/dark.xml b/share/qtcreator/styles/dark.xml index 0a2338d1671..b7edf68469e 100644 --- a/share/qtcreator/styles/dark.xml +++ b/share/qtcreator/styles/dark.xml @@ -22,6 +22,7 @@