feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove qDebug from ConnectionView

Browse Source 
Change-Id: I495525286ff96331ce560d468bf1445fcf7a061e
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
This commit is contained in:
Thomas Hartmann
2023-09-15 12:53:07 +02:00
parent 6d5ceadccf
commit b0a9481049
2 changed files with 2 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/plugins/qmldesigner/components/connectioneditor/connectionmodel.cpp
View File

@@ -652,7 +652,6 @@ QString generateDefaultStatement(ConnectionModelBackendDelegate::ActionType acti
void ConnectionModelBackendDelegate::changeActionType(ActionType actionType) void ConnectionModelBackendDelegate::changeActionType(ActionType actionType)
{ {
qDebug() << Q_FUNC_INFO << actionType;
QTC_ASSERT(actionType != ConnectionModelStatementDelegate::Custom, return ); QTC_ASSERT(actionType != ConnectionModelStatementDelegate::Custom, return );
ConnectionModel *model = qobject_cast<ConnectionModel *>(parent()); ConnectionModel *model = qobject_cast<ConnectionModel *>(parent());
@@ -676,9 +675,9 @@ void ConnectionModelBackendDelegate::changeActionType(ActionType actionType)
QString statementSource = generateDefaultStatement(actionType, validId); QString statementSource = generateDefaultStatement(actionType, validId);
auto tempHandler = ConnectionEditorEvaluator::parseStatement(statementSource); auto tempHandler = ConnectionEditorEvaluator::parseStatement(statementSource);
qDebug() << ConnectionEditorStatements::toString(tempHandler);
auto newOkStatement = ConnectionEditorStatements::okStatement(tempHandler); auto newOkStatement = ConnectionEditorStatements::okStatement(tempHandler);
qDebug() << "newOk" << statementSource;
QTC_ASSERT(!ConnectionEditorStatements::isEmptyStatement(newOkStatement), return ); QTC_ASSERT(!ConnectionEditorStatements::isEmptyStatement(newOkStatement), return );
okStatement = newOkStatement; okStatement = newOkStatement;
@@ -849,9 +848,6 @@ void ConnectionModelBackendDelegate::update()
setupHandlerAndStatements(); setupHandlerAndStatements();
qDebug() << Q_FUNC_INFO << ConnectionEditorStatements::toString(m_handler)
<< ConnectionEditorStatements::toJavascript(m_handler);
setupCondition(); setupCondition();
QTC_ASSERT(model, return ); QTC_ASSERT(model, return );
@@ -1440,7 +1436,6 @@ void ConnectionModelStatementDelegate::setupCallFunction()
void ConnectionModelStatementDelegate::setupChangeState() void ConnectionModelStatementDelegate::setupChangeState()
{ {
qDebug() << Q_FUNC_INFO;
QTC_ASSERT(std::holds_alternative<ConnectionEditorStatements::StateSet>(m_statement), return ); QTC_ASSERT(std::holds_alternative<ConnectionEditorStatements::StateSet>(m_statement), return );
QTC_ASSERT(m_model->connectionView()->isAttached(), return ); QTC_ASSERT(m_model->connectionView()->isAttached(), return );
@@ -1494,8 +1489,6 @@ void ConnectionModelStatementDelegate::setupStates()
const auto stateSet = std::get<ConnectionEditorStatements::StateSet>(m_statement); const auto stateSet = std::get<ConnectionEditorStatements::StateSet>(m_statement);
qDebug() << Q_FUNC_INFO << stateSet.stateName;
const QString nodeId = m_stateTargets.currentText(); const QString nodeId = m_stateTargets.currentText();
const ModelNode node = m_model->connectionView()->modelNodeForId(nodeId); const ModelNode node = m_model->connectionView()->modelNodeForId(nodeId);
@@ -1752,20 +1745,16 @@ void ConditionListModel::command(const QString &string)
//TODO remove from prodcution code //TODO remove from prodcution code
QStringList list = string.split("%", Qt::SkipEmptyParts); QStringList list = string.split("%", Qt::SkipEmptyParts);
qDebug() << Q_FUNC_INFO << string << list.size();
if (list.size() < 2) if (list.size() < 2)
return; return;
if (list.size() == 2) { if (list.size() == 2) {
if (list.first() == "A") { if (list.first() == "A") {
qDebug() << "Append" << list.last();
appendToken(list.last()); appendToken(list.last());
} else if (list.first() == "R") { } else if (list.first() == "R") {
bool ok = true; bool ok = true;
int index = list.last().toInt(&ok); int index = list.last().toInt(&ok);
qDebug() << "Remove" << index;
if (ok) if (ok)
removeToken(index); removeToken(index);
} }
@@ -1778,15 +1767,12 @@ void ConditionListModel::command(const QString &string)
if (ok) if (ok)
updateToken(index, list.last()); updateToken(index, list.last());
qDebug() << "Update" << index << list.last();
} else if (list.first() == "I") { } else if (list.first() == "I") {
bool ok = true; bool ok = true;
int index = list.at(1).toInt(&ok); int index = list.at(1).toInt(&ok);
if (ok) if (ok)
insertToken(index, list.last()); insertToken(index, list.last());
qDebug() << "Insert" << index << list.last();
} }
} }
} }

1
src/plugins/qmldesigner/components/connectioneditor/propertytreemodel.cpp
View File

@@ -520,7 +520,6 @@ const std::vector<PropertyName> PropertyTreeModel::getDynamicProperties(
const std::vector<PropertyName> PropertyTreeModel::sortedAndFilteredPropertyNames( const std::vector<PropertyName> PropertyTreeModel::sortedAndFilteredPropertyNames(
const NodeMetaInfo &metaInfo, bool recursive) const const NodeMetaInfo &metaInfo, bool recursive) const
{ {
qDebug() << Q_FUNC_INFO << metaInfo.typeName() << recursive;
auto filtered = Utils::filtered(metaInfo.properties(), auto filtered = Utils::filtered(metaInfo.properties(),
[this, recursive](const PropertyMetaInfo &metaInfo) { [this, recursive](const PropertyMetaInfo &metaInfo) {
// if (!metaInfo.isWritable()) - lhs/rhs // if (!metaInfo.isWritable()) - lhs/rhs