feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PropertyEditorValue: improvement for isTranslated

Browse Source 
isTranslated needs to take into account dynamic properties as well so the highlight of 'tr' button works properly for translated dynamic properties in the property editor.

Task-number: QDS-13513
Change-Id: I8694dc0b3b3d02351868fbe9a0777c6e4f1b6ee5
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Rafal Stawarski
2025-03-11 10:44:45 +01:00
parent 500e1e29ba
commit b0af280b3f
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qmldesigner/components/propertyeditor/propertyeditorvalue.cpp
View File

@@ -222,9 +222,15 @@ void PropertyEditorValue::setIsValid(bool valid)
bool PropertyEditorValue::isTranslated() const bool PropertyEditorValue::isTranslated() const
{ {
if (modelNode().isValid()) { if (modelNode().isValid()) {
if (auto metaInfo = modelNode().metaInfo(); auto metaInfo = modelNode().metaInfo();
metaInfo.isValid() && metaInfo.hasProperty(name()) auto isString = metaInfo.isValid() && metaInfo.hasProperty(name())
&& metaInfo.property(name()).propertyType().isString()) { && metaInfo.property(name()).propertyType().isString();
auto property = modelNode().property(name());
auto isDynamicString = property.isValid() && property.isDynamic()
&& property.dynamicTypeName() == TypeNameView("string");
if (isString || isDynamicString) {
const QmlObjectNode objectNode(modelNode()); const QmlObjectNode objectNode(modelNode());
if (objectNode.hasBindingProperty(name())) { if (objectNode.hasBindingProperty(name())) {
const QRegularExpression rx( const QRegularExpression rx(