Android: Some code cosmetics

The naming scheme of the internal object was changed
to the usual pimpl pattern.

Also setup device update connection in the device constructory

Change-Id: I5cbb7a9d870a7d1f0e91e54f2ad6dfb95ea63e37
Reviewed-by: Vikas Pachdha <vikas.pachdha@qt.io>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/android/androidconfigurations.cpp

@@ -1145,6 +1145,8 @@ AndroidConfigurations::AndroidConfigurations()
 
     connect(SessionManager::instance(), &SessionManager::projectRemoved,
             this, &AndroidConfigurations::clearDefaultDevices);
+    connect(DeviceManager::instance(), &DeviceManager::devicesLoaded,
+            this, &AndroidConfigurations::updateAndroidDevice);
 
     m_force32bit = is32BitUserSpace();
 

src/plugins/android/androidconfigurations.h

@@ -52,9 +52,11 @@ class Project;
 
 namespace Android {
 
-class AndroidPluginRunData;
 
-namespace Internal { class AndroidSdkManager; }
+namespace Internal {
+class AndroidSdkManager;
+class AndroidPluginPrivate;
+}
 
 class AndroidDeviceInfo
 {
@@ -195,7 +197,6 @@ public:
     static void setConfig(const AndroidConfig &config);
     static AndroidConfigurations *instance();
 
-    static void updateAndroidDevice();
     static AndroidDeviceInfo showDeviceDialog(ProjectExplorer::Project *project, int apiLevel, const QString &abi);
     static void setDefaultDevice(ProjectExplorer::Project *project, const QString &abi, const QString &serialNumber); // serial number or avd name
     static QString defaultDevice(ProjectExplorer::Project *project, const QString &abi); // serial number or avd name
@@ -210,12 +211,13 @@ signals:
     void updated();
 
 private:
-    friend class Android::AndroidPluginRunData;
+    friend class Android::Internal::AndroidPluginPrivate;
     AndroidConfigurations();
     ~AndroidConfigurations();
     void load();
     void save();
 
+    static void updateAndroidDevice();
     static AndroidConfigurations *m_instance;
     AndroidConfig m_config;
     std::unique_ptr<Internal::AndroidSdkManager> m_sdkManager;

src/plugins/android/androidplugin.cpp

@@ -56,11 +56,11 @@
 
 using namespace ProjectExplorer;
 using namespace ProjectExplorer::Constants;
-using namespace Android::Internal;
 
 namespace Android {
+namespace Internal {
 
-class AndroidPluginRunData
+class AndroidPluginPrivate
 {
 public:
     AndroidConfigurations androidConfiguration;
@@ -76,12 +76,9 @@ public:
     AndroidManifestEditorFactory manifestEditorFactory;
 };
 
-AndroidPlugin::AndroidPlugin()
-{ }
-
 AndroidPlugin::~AndroidPlugin()
 {
-    delete m_runData;
+    delete d;
 }
 
 bool AndroidPlugin::initialize(const QStringList &arguments, QString *errorMessage)
@@ -96,15 +93,13 @@ bool AndroidPlugin::initialize(const QStringList &arguments, QString *errorMessa
     RunControl::registerWorker<AndroidRunConfiguration, AndroidQmlToolingSupport>(
                 QML_PREVIEW_RUN_MODE);
 
-    m_runData = new AndroidPluginRunData;
+    d = new AndroidPluginPrivate;
 
     KitManager::registerKitInformation(new Internal::AndroidGdbServerKitInformation);
 
     connect(KitManager::instance(), &KitManager::kitsLoaded,
             this, &AndroidPlugin::kitsRestored);
 
-    connect(DeviceManager::instance(), &DeviceManager::devicesLoaded,
-            this, &AndroidPlugin::updateDevice);
     return true;
 }
 
@@ -117,9 +112,5 @@ void AndroidPlugin::kitsRestored()
                this, &AndroidPlugin::kitsRestored);
 }
 
-void AndroidPlugin::updateDevice()
+} // namespace Internal
-{
-    AndroidConfigurations::updateAndroidDevice();
-}
-
 } // namespace Android

src/plugins/android/androidplugin.h

@@ -28,16 +28,15 @@
 #include <extensionsystem/iplugin.h>
 
 namespace Android {
-
+namespace Internal {
-class AndroidPluginRunData;
+class AndroidPluginPrivate;
-
 class AndroidPlugin : public ExtensionSystem::IPlugin
 {
     Q_OBJECT
     Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "Android.json")
 
 public:
-    AndroidPlugin();
+    AndroidPlugin() = default;
 
 private:
     ~AndroidPlugin() final;
@@ -45,10 +44,10 @@ private:
     bool initialize(const QStringList &arguments, QString *errorMessage) final;
     void extensionsInitialized() final { }
 
-    void updateDevice();
     void kitsRestored();
 
-    AndroidPluginRunData *m_runData = nullptr;
+    AndroidPluginPrivate *d = nullptr;
 };
 
+} // namespace Internal
 } // namespace Android