forked from qt-creator/qt-creator
Debugger: Drop base DebuggerEngine::runEngine()
The lines between engine setup and running have always been blurry, so it looks more and more unnatural to enforce this in the architecture. Remove the runEngine() call from the end of notifySetupEngineOk, and do it on the user side. Change-Id: I3a5e158e8b3fe9b0a288d064f798e24b2ac47f86 Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
@@ -3916,6 +3916,7 @@ void GdbEngine::finishInferiorSetup()
|
||||
// and even if it fails (e.g. due to stripped binaries), continuing with
|
||||
// the start up is the best we can do.
|
||||
notifyEngineSetupOk();
|
||||
runEngine();
|
||||
}
|
||||
|
||||
void GdbEngine::handleDebugInfoLocation(const DebuggerResponse &response)
|
||||
@@ -4091,6 +4092,7 @@ void GdbEngine::setupInferior()
|
||||
if (rp.startMode == AttachToRemoteProcess) {
|
||||
|
||||
notifyEngineSetupOk();
|
||||
runEngine();
|
||||
|
||||
} else if (isAttachEngine()) {
|
||||
// Task 254674 does not want to remove them
|
||||
|
||||
Reference in New Issue
Block a user