feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditorWidget: Ensure non-null source is passed to insertFromMimeData

Browse Source 
Detected by clazy analyzer. The possible context was
TextEditorWidget::dropEvent(). In some branches we ensure
that mime is not null, but later we call insertFromMimeData()
unconditionally.

Change-Id: Iee5138bc19d405050eafc9617d3c2ed123b767c7
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Jarek Kobus
2022-12-07 16:55:38 +01:00
parent 6bef53a818
commit b0e6943491
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/texteditor/texteditor.cpp
View File

@@ -7847,7 +7847,7 @@ struct MappedText
void TextEditorWidget::insertFromMimeData(const QMimeData *source) void TextEditorWidget::insertFromMimeData(const QMimeData *source)
{ {
if (isReadOnly()) if (!source || isReadOnly())
return; return;
QString text = source->text(); QString text = source->text();
@@ -7857,7 +7857,6 @@ void TextEditorWidget::insertFromMimeData(const QMimeData *source)
if (d->m_codeAssistant.hasContext()) if (d->m_codeAssistant.hasContext())
d->m_codeAssistant.destroyContext(); d->m_codeAssistant.destroyContext();
if (d->m_snippetOverlay->isVisible() && (text.contains('\n') || text.contains('\t'))) if (d->m_snippetOverlay->isVisible() && (text.contains('\n') || text.contains('\t')))
d->m_snippetOverlay->accept(); d->m_snippetOverlay->accept();