feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Fix infinite recursion

Browse Source 
If some ProjectNode doesn't override supportsAction (like CMake), then the
fallback is FolderNode, which calls the root project node again...

Change-Id: Ie7a469d6aaaae38c8c2ff56e33fed27cf1477b49
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Orgad Shaneh
2017-04-06 23:42:17 +03:00
committed by Tobias Hunger
parent d186d85bcf
commit b1180280d0
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/projectexplorer/projectnodes.cpp
View File

@@ -773,6 +773,11 @@ bool ProjectNode::renameFile(const QString &filePath, const QString &newFilePath
return false; return false;
} }
bool ProjectNode::supportsAction(ProjectAction, Node *) const
{
return false;
}
bool ProjectNode::deploysFolder(const QString &folder) const bool ProjectNode::deploysFolder(const QString &folder) const
{ {
Q_UNUSED(folder); Q_UNUSED(folder);

1
src/plugins/projectexplorer/projectnodes.h
View File

@@ -291,6 +291,7 @@ public:
bool deleteFiles(const QStringList &filePaths) override; bool deleteFiles(const QStringList &filePaths) override;
bool canRenameFile(const QString &filePath, const QString &newFilePath) override; bool canRenameFile(const QString &filePath, const QString &newFilePath) override;
bool renameFile(const QString &filePath, const QString &newFilePath) override; bool renameFile(const QString &filePath, const QString &newFilePath) override;
bool supportsAction(ProjectAction action, Node *node) const override;
// by default returns false // by default returns false
virtual bool deploysFolder(const QString &folder) const; virtual bool deploysFolder(const QString &folder) const;