From b17de35ef416f43ef28506e8d24aaa636848a6b6 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 19 Mar 2020 15:15:01 +0100 Subject: [PATCH] Debugger: Add separator between cdb extension paths According to https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/ general-environment-variables extension paths have to be separated by a semicolon. Skipping the separator results in not being able to debug with cdb since the debugger cannot find the Qt Creator cdbextension in the now invalid extension path. Change-Id: Ic1c478dbb94f4e774e6742a3800dbcf6452898d5 Reviewed-by: Christian Kandeler Reviewed-by: Eike Ziller --- src/plugins/debugger/cdb/cdbengine.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/plugins/debugger/cdb/cdbengine.cpp b/src/plugins/debugger/cdb/cdbengine.cpp index 798013ed42f..7685dedaf6a 100644 --- a/src/plugins/debugger/cdb/cdbengine.cpp +++ b/src/plugins/debugger/cdb/cdbengine.cpp @@ -441,11 +441,12 @@ void CdbEngine::setupEngine() inferiorEnvironment.set(qtLoggingToConsoleKey, "0"); static const char cdbExtensionPathVariableC[] = "_NT_DEBUGGER_EXTENSION_PATH"; - inferiorEnvironment.prependOrSet(cdbExtensionPathVariableC, extensionFi.absolutePath()); + inferiorEnvironment.prependOrSet(cdbExtensionPathVariableC, extensionFi.absolutePath(), {";"}); const QByteArray oldCdbExtensionPath = qgetenv(cdbExtensionPathVariableC); if (!oldCdbExtensionPath.isEmpty()) { inferiorEnvironment.appendOrSet(cdbExtensionPathVariableC, - QString::fromLocal8Bit(oldCdbExtensionPath)); + QString::fromLocal8Bit(oldCdbExtensionPath), + {";"}); } m_process.setEnvironment(inferiorEnvironment);