feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Refuse to add properties from unselected nodes

Browse Source 
... and select property after adding it to the model.

Change-Id: I4210e9b1e27b3d396ba5f421629a2b90d2771f50
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Knud Dollereder
2023-09-15 14:16:20 +02:00
parent 5ca59da1af
commit b18b7920bb
2 changed files with 16 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/qmldesigner/components/connectioneditor/bindingmodel.cpp
View File

@@ -144,11 +144,15 @@ void BindingModel::setCurrentProperty(const AbstractProperty &property)
void BindingModel::updateItem(const BindingProperty &property) void BindingModel::updateItem(const BindingProperty &property)
{ {
if (auto *item = itemForProperty(property)) if (auto *item = itemForProperty(property)) {
item->updateProperty(property); item->updateProperty(property);
else } else {
appendRow(new BindingModelItem(property)); ModelNode node = property.parentModelNode();
if (connectionView()->isSelectedModelNode(node)) {
appendRow(new BindingModelItem(property));
setCurrentProperty(property);
}
}
m_delegate->update(currentProperty(), m_connectionView); m_delegate->update(currentProperty(), m_connectionView);
} }

11
src/plugins/qmldesigner/components/connectioneditor/dynamicpropertiesmodel.cpp
View File

@@ -151,10 +151,15 @@ void DynamicPropertiesModel::updateItem(const AbstractProperty &property)
if (!property.isDynamic()) if (!property.isDynamic())
return; return;
if (auto *item = itemForProperty(property)) if (auto *item = itemForProperty(property)) {
item->updateProperty(property); item->updateProperty(property);
else } else {
addProperty(property); ModelNode node = property.parentModelNode();
if (selectedNodes().contains(node)) {
addProperty(property);
setCurrentProperty(property);
}
}
} }
void DynamicPropertiesModel::removeItem(const AbstractProperty &property) void DynamicPropertiesModel::removeItem(const AbstractProperty &property)