KitInformationConfigWidget: Clean up header a bit

Change-Id: I0e8d92a5b58a6045240a18d655f6a02ae3165804
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-10-13 12:33:20 +02:00
parent b26077a7a4
commit b1dced66d7
2 changed files with 15 additions and 27 deletions

View File

@@ -67,8 +67,7 @@ namespace Internal {
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------
SysRootInformationConfigWidget::SysRootInformationConfigWidget(Kit *k, const KitInformation *ki) : SysRootInformationConfigWidget::SysRootInformationConfigWidget(Kit *k, const KitInformation *ki) :
KitConfigWidget(k, ki), KitConfigWidget(k, ki)
m_ignoreChange(false)
{ {
m_chooser = new Utils::PathChooser; m_chooser = new Utils::PathChooser;
m_chooser->setExpectedKind(Utils::PathChooser::ExistingDirectory); m_chooser->setExpectedKind(Utils::PathChooser::ExistingDirectory);
@@ -127,9 +126,7 @@ void SysRootInformationConfigWidget::pathWasChanged()
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------
ToolChainInformationConfigWidget::ToolChainInformationConfigWidget(Kit *k, const KitInformation *ki) : ToolChainInformationConfigWidget::ToolChainInformationConfigWidget(Kit *k, const KitInformation *ki) :
KitConfigWidget(k, ki), KitConfigWidget(k, ki)
m_ignoreChanges(false),
m_isReadOnly(false)
{ {
m_comboBox = new QComboBox; m_comboBox = new QComboBox;
m_comboBox->setToolTip(toolTip()); m_comboBox->setToolTip(toolTip());
@@ -291,8 +288,6 @@ void DeviceTypeInformationConfigWidget::currentTypeChanged(int idx)
DeviceInformationConfigWidget::DeviceInformationConfigWidget(Kit *workingCopy, const KitInformation *ki) : DeviceInformationConfigWidget::DeviceInformationConfigWidget(Kit *workingCopy, const KitInformation *ki) :
KitConfigWidget(workingCopy, ki), KitConfigWidget(workingCopy, ki),
m_isReadOnly(false),
m_ignoreChange(false),
m_comboBox(new QComboBox), m_comboBox(new QComboBox),
m_model(new DeviceManagerModel(DeviceManager::instance())) m_model(new DeviceManagerModel(DeviceManager::instance()))
{ {
@@ -382,9 +377,7 @@ void DeviceInformationConfigWidget::currentDeviceChanged()
KitEnvironmentConfigWidget::KitEnvironmentConfigWidget(Kit *workingCopy, const KitInformation *ki) : KitEnvironmentConfigWidget::KitEnvironmentConfigWidget(Kit *workingCopy, const KitInformation *ki) :
KitConfigWidget(workingCopy, ki), KitConfigWidget(workingCopy, ki),
m_summaryLabel(new QLabel), m_summaryLabel(new QLabel),
m_manageButton(new QPushButton), m_manageButton(new QPushButton)
m_dialog(0),
m_editor(0)
{ {
refresh(); refresh();
m_manageButton->setText(tr("Change...")); m_manageButton->setText(tr("Change..."));

View File

@@ -72,12 +72,11 @@ public:
QWidget *mainWidget() const; QWidget *mainWidget() const;
QString toolTip() const; QString toolTip() const;
private slots: private:
void pathWasChanged(); void pathWasChanged();
private:
Utils::PathChooser *m_chooser; Utils::PathChooser *m_chooser;
bool m_ignoreChange; bool m_ignoreChange = false;
}; };
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------
@@ -99,17 +98,16 @@ public:
QWidget *buttonWidget() const; QWidget *buttonWidget() const;
QString toolTip() const; QString toolTip() const;
private slots: private:
void manageToolChains(); void manageToolChains();
void currentToolChainChanged(int idx); void currentToolChainChanged(int idx);
private:
int indexOf(const ToolChain *tc); int indexOf(const ToolChain *tc);
QComboBox *m_comboBox; QComboBox *m_comboBox;
QPushButton *m_manageButton; QPushButton *m_manageButton;
bool m_ignoreChanges; bool m_ignoreChanges = false;
bool m_isReadOnly; bool m_isReadOnly = false;
}; };
// -------------------------------------------------------------------------- // --------------------------------------------------------------------------
@@ -130,10 +128,9 @@ public:
void refresh(); void refresh();
void makeReadOnly(); void makeReadOnly();
private slots: private:
void currentTypeChanged(int idx); void currentTypeChanged(int idx);
private:
QComboBox *m_comboBox; QComboBox *m_comboBox;
}; };
@@ -156,15 +153,14 @@ public:
void refresh(); void refresh();
void makeReadOnly(); void makeReadOnly();
private slots: private:
void manageDevices(); void manageDevices();
void modelAboutToReset(); void modelAboutToReset();
void modelReset(); void modelReset();
void currentDeviceChanged(); void currentDeviceChanged();
private: bool m_isReadOnly = false;
bool m_isReadOnly; bool m_ignoreChange = false;
bool m_ignoreChange;
QComboBox *m_comboBox; QComboBox *m_comboBox;
QPushButton *m_manageButton; QPushButton *m_manageButton;
DeviceManagerModel *m_model; DeviceManagerModel *m_model;
@@ -185,18 +181,17 @@ public:
void refresh(); void refresh();
void makeReadOnly(); void makeReadOnly();
private slots: private:
void editEnvironmentChanges(); void editEnvironmentChanges();
void applyChanges(); void applyChanges();
void closeChangesDialog(); void closeChangesDialog();
void acceptChangesDialog(); void acceptChangesDialog();
private:
QLabel *m_summaryLabel; QLabel *m_summaryLabel;
QPushButton *m_manageButton; QPushButton *m_manageButton;
QDialog *m_dialog; QDialog *m_dialog = 0;
QPlainTextEdit *m_editor; QPlainTextEdit *m_editor = 0;
}; };
} // namespace Internal } // namespace Internal