feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fixed a problem with adding files when final newline is missing

Browse Source 
When there was no final newline in the .files file, the name of the
first new file would get appended to the name of the last file. This
patch fixes that by simply rewriting the whole file.

Also switched to writing out native line endings.
This commit is contained in:
Thorbjørn Lindeijer
2009-06-29 18:42:59 +02:00
parent 79e2108687
commit b210943b0a
1 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/plugins/genericprojectmanager/genericproject.cpp
View File

@@ -170,18 +170,22 @@ static QStringList readLines(const QString &absoluteFileName)
bool GenericProject::addFiles(const QStringList &filePaths)
{
// Make sure we can open the file for writing
QFile file(filesFileName());
if (file.open(QFile::Append)) {
QTextStream stream(&file);
QDir baseDir(QFileInfo(m_fileName).dir());
foreach (const QString &filePath, filePaths) {
stream << baseDir.relativeFilePath(filePath) << "\n";
}
file.close();
refresh(GenericProject::Files);
return true;
}
return false;
if (!file.open(QIODevice::WriteOnly | QIODevice::Text))
return false;
QStringList newFileList = m_files;
newFileList.append(filePaths);
QTextStream stream(&file);
QDir baseDir(QFileInfo(m_fileName).dir());
foreach (const QString &filePath, newFileList)
stream << baseDir.relativeFilePath(filePath) << QLatin1Char('\n');
file.close();
refresh(GenericProject::Files);
return true;
}
void GenericProject::parseProject(RefreshOptions options)