From b2114507da04ad9d2fc1283db2379831185f54e1 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 7 Oct 2024 10:32:50 +0200 Subject: [PATCH] ExtensionManager: Use QPushButton::clicked, not pressed "Clicked" is "press and release", and we use that when reacting to buttons. Opening the window on "pressed" leads to the "released" event not being handled by the QPushButton, which confuses Qt on macOS and leads to an ugly gray background staying around after using it. Change-Id: Ieff15d222cdaeffd498594ca300e960421493940 Reviewed-by: Alessandro Portale --- src/plugins/extensionmanager/extensionsbrowser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/extensionmanager/extensionsbrowser.cpp b/src/plugins/extensionmanager/extensionsbrowser.cpp index 2d2d696210c..2e14aa6df19 100644 --- a/src/plugins/extensionmanager/extensionsbrowser.cpp +++ b/src/plugins/extensionmanager/extensionsbrowser.cpp @@ -590,7 +590,7 @@ ExtensionsBrowser::ExtensionsBrowser(ExtensionsModel *model, QWidget *parent) d->sortFilterProxyModel, &SortFilterProxyModel::setSortOption); connect(d->filterChooser, &OptionChooser::currentIndexChanged, d->sortFilterProxyModel, &SortFilterProxyModel::setFilterOption); - connect(settingsToolButton, &QAbstractButton::pressed, this, []() { + connect(settingsToolButton, &QAbstractButton::clicked, this, []() { ICore::showOptionsDialog(Constants::EXTENSIONMANAGER_SETTINGSPAGE_ID); }); connect(&settings(), &AspectContainer::changed, this, [this]() {