feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: const correct ShowMessageParams::toString()

Browse Source 
Change-Id: I663c57aff8b23acbdaca1149e59f8f5f35bcfb94
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
David Schulz
2018-09-12 08:14:25 +02:00
parent 8c1edd5c54
commit b236874d2e
4 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/languageserverprotocol/messages.cpp
View File

@@ -67,7 +67,7 @@ static QString messageTypeName(int messageType)
return QString(""); return QString("");
} }
QString ShowMessageParams::toString() QString ShowMessageParams::toString() const
{ {
return messageTypeName(type()) + ": " + message(); return messageTypeName(type()) + ": " + message();
} }

2
src/libs/languageserverprotocol/messages.h
View File

@@ -47,7 +47,7 @@ public:
QString message() const { return typedValue<QString>(messageKey); } QString message() const { return typedValue<QString>(messageKey); }
void setMessage(QString message) { insert(messageKey, message); } void setMessage(QString message) { insert(messageKey, message); }
QString toString(); QString toString() const;
bool isValid(QStringList *error) const override bool isValid(QStringList *error) const override
{ return check<int>(error, typeKey) && check<QString>(error, messageKey); } { return check<int>(error, typeKey) && check<QString>(error, messageKey); }

3
src/plugins/languageclient/baseclient.cpp
View File

@@ -516,7 +516,8 @@ void BaseClient::log(const QString &message, Core::MessageManager::PrintToOutput
Core::MessageManager::write(QString("LanguageClient %1: %2").arg(name(), message), flag); Core::MessageManager::write(QString("LanguageClient %1: %2").arg(name(), message), flag);
} }
void BaseClient::log(LogMessageParams &message, Core::MessageManager::PrintToOutputPaneFlag flag) void BaseClient::log(const LogMessageParams &message,
Core::MessageManager::PrintToOutputPaneFlag flag)
{ {
log(message.toString(), flag); log(message.toString(), flag);
} }

2
src/plugins/languageclient/baseclient.h
View File

@@ -118,7 +118,7 @@ public:
void log(const QString &message, void log(const QString &message,
Core::MessageManager::PrintToOutputPaneFlag flag = Core::MessageManager::NoModeSwitch); Core::MessageManager::PrintToOutputPaneFlag flag = Core::MessageManager::NoModeSwitch);
void log(LanguageServerProtocol::LogMessageParams &message, void log(const LanguageServerProtocol::LogMessageParams &message,
Core::MessageManager::PrintToOutputPaneFlag flag = Core::MessageManager::NoModeSwitch); Core::MessageManager::PrintToOutputPaneFlag flag = Core::MessageManager::NoModeSwitch);
signals: signals: