feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't access static functions/fields via instance

Browse Source 
Courtesy of readability-static-accessed-through-instance

Change-Id: I71f54244f1e091315dac2943d9e1bfad6efa56a9
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2020-11-18 22:42:51 +01:00
parent 0c0347ce61
commit b2a766a79a
52 changed files with 126 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cpptools/builtineditordocumentparser.cpp
View File

@@ -175,7 +175,7 @@ void BuiltinEditorDocumentParser::updateImpl(const QFutureInterface<void> &futur
// Update the snapshot
if (invalidateSnapshot) {
const QString configurationFileName = modelManager->configurationFileName();
const QString configurationFileName = CppModelManager::configurationFileName();
if (invalidateConfig)
state.snapshot.remove(configurationFileName);
if (!state.snapshot.contains(configurationFileName))

2
src/plugins/cpptools/cppcompletionassist.cpp
View File

@@ -804,7 +804,7 @@ const Name *minimalName(Symbol *symbol, Scope *targetScope, const LookupContext
ClassOrNamespace *target = context.lookupType(targetScope);
if (!target)
target = context.globalNamespace();
return context.minimalName(symbol, target, context.bindings()->control().data());
return LookupContext::minimalName(symbol, target, context.bindings()->control().data());
}
} // Anonymous

5
src/plugins/cpptools/cppfindreferences.cpp
View File

@@ -333,7 +333,7 @@ void CppFindReferences::findUsages(CPlusPlus::Symbol *symbol,
CPlusPlus::Overview overview;
SearchResult *search = SearchResultWindow::instance()->startNewSearch(tr("C++ Usages:"),
QString(),
overview.prettyName(context.fullyQualifiedName(symbol)),
overview.prettyName(CPlusPlus::LookupContext::fullyQualifiedName(symbol)),
replace ? SearchResultWindow::SearchAndReplace
: SearchResultWindow::SearchOnly,
SearchResultWindow::PreserveCaseDisabled,
@@ -352,7 +352,8 @@ void CppFindReferences::findUsages(CPlusPlus::Symbol *symbol,
if (symbol->isClass() || symbol->isForwardClassDeclaration()) {
CPlusPlus::Overview overview;
parameters.prettySymbolName = overview.prettyName(context.path(symbol).constLast());
parameters.prettySymbolName =
overview.prettyName(CPlusPlus::LookupContext::path(symbol).constLast());
}
search->setUserData(QVariant::fromValue(parameters));

2
src/plugins/cpptools/cpptoolsplugin.cpp
View File

@@ -131,7 +131,7 @@ Utils::FilePath CppToolsPlugin::licenseTemplatePath()
QString CppToolsPlugin::licenseTemplate()
{
return m_instance->d->m_fileSettings.licenseTemplate();
return CppFileSettings::licenseTemplate();
}
bool CppToolsPlugin::usePragmaOnce()