feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Locator: Cleanup and modernize Locator and filters

Browse Source 
* Omit QLatin1{Char|String}
* Use member initialization
* Use range-based-for
  (and fixed the cases with non-const Qt container)
* Sort includes to common style

Change-Id: Ibc33a732bb153862efd6d5febfac758229cb61d4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Andre Hartmann
2017-12-29 09:11:27 +01:00
committed by André Hartmann
parent ccc0bebcf4
commit b2aa1b9845
42 changed files with 238 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/cmakeprojectmanager/cmakelocatorfilter.cpp
View File

@@ -45,7 +45,7 @@ CMakeLocatorFilter::CMakeLocatorFilter()
{
setId("Build CMake target");
setDisplayName(tr("Build CMake target"));
setShortcutString(QLatin1String("cm"));
setShortcutString("cm");
setPriority(High);
connect(SessionManager::instance(), &SessionManager::projectAdded,
@@ -60,11 +60,13 @@ CMakeLocatorFilter::CMakeLocatorFilter()
void CMakeLocatorFilter::prepareSearch(const QString &entry)
{
m_result.clear();
for (Project *p : SessionManager::projects()) {
const QList<Project *> projects = SessionManager::projects();
for (Project *p : projects) {
CMakeProject *cmakeProject = qobject_cast<CMakeProject *>(p);
if (!cmakeProject)
continue;
foreach (const QString &title, cmakeProject->buildTargetTitles()) {
const QStringList buildTargetTitles = cmakeProject->buildTargetTitles();
for (const QString &title : buildTargetTitles) {
const int index = title.indexOf(entry);
if (index >= 0) {
Core::LocatorFilterEntry filterEntry(this, title, cmakeProject->projectFilePath().toString());