feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LanguageClient: Modernize

Browse Source 
modernize-*

Change-Id: I966de09934b9ba3b0497d1df5744c8c3f826240f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Alessandro Portale
2018-11-14 01:21:20 +01:00
parent 88b43d54c3
commit b2cea9474c
6 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/languageclient/baseclient.cpp
View File

@@ -609,7 +609,7 @@ void BaseClient::handleMethod(const QString &method, MessageId id, const IConten
if (paramsValid) if (paramsValid)
log(params); log(params);
} else if (method == ShowMessageRequest::methodName) { } else if (method == ShowMessageRequest::methodName) {
const ShowMessageRequest *request = dynamic_cast<const ShowMessageRequest *>(content); auto request = dynamic_cast<const ShowMessageRequest *>(content);
auto params = request->params().value_or(ShowMessageRequestParams()); auto params = request->params().value_or(ShowMessageRequestParams());
paramsValid = params.isValid(&error); paramsValid = params.isValid(&error);
if (paramsValid) { if (paramsValid) {

2
src/plugins/languageclient/dynamiccapabilities.h
View File

@@ -33,7 +33,7 @@ class DynamicCapability
{ {
public: public:
DynamicCapability() = default; DynamicCapability() = default;
void enable(QString id, QJsonValue options) void enable(const QString &id, const QJsonValue &options)
{ {
QTC_CHECK(!m_enabled); QTC_CHECK(!m_enabled);
m_enabled = true; m_enabled = true;

2
src/plugins/languageclient/languageclientmanager.cpp
View File

@@ -290,7 +290,7 @@ void LanguageClientManager::editorOpened(Core::IEditor *iEditor)
} }
} }
void LanguageClientManager::editorsClosed(const QList<Core::IEditor *> editors) void LanguageClientManager::editorsClosed(const QList<Core::IEditor *> &editors)
{ {
for (auto iEditor : editors) { for (auto iEditor : editors) {
if (auto editor = qobject_cast<TextEditor::BaseTextEditor *>(iEditor)) { if (auto editor = qobject_cast<TextEditor::BaseTextEditor *>(iEditor)) {

6
src/plugins/languageclient/languageclientmanager.h
View File

@@ -49,6 +49,8 @@ class LanguageClientManager : public QObject
{ {
Q_OBJECT Q_OBJECT
public: public:
LanguageClientManager(const LanguageClientManager &other) = delete;
LanguageClientManager(LanguageClientManager &&other) = delete;
~LanguageClientManager() override; ~LanguageClientManager() override;
static void init(); static void init();
@@ -78,11 +80,9 @@ signals:
private: private:
LanguageClientManager(); LanguageClientManager();
LanguageClientManager(const LanguageClientManager &other) = delete;
LanguageClientManager(LanguageClientManager &&other) = delete;
void editorOpened(Core::IEditor *editor); void editorOpened(Core::IEditor *editor);
void editorsClosed(const QList<Core::IEditor *> editors); void editorsClosed(const QList<Core::IEditor *> &editors);
void documentContentsSaved(Core::IDocument *document); void documentContentsSaved(Core::IDocument *document);
void documentWillSave(Core::IDocument *document); void documentWillSave(Core::IDocument *document);
void findLinkAt(const Utils::FileName &filePath, const QTextCursor &cursor, void findLinkAt(const Utils::FileName &filePath, const QTextCursor &cursor,

2
src/plugins/languageclient/languageclientsettings.cpp
View File

@@ -70,7 +70,7 @@ class LanguageClientSettingsModel : public QAbstractListModel
{ {
public: public:
LanguageClientSettingsModel() = default; LanguageClientSettingsModel() = default;
~LanguageClientSettingsModel(); ~LanguageClientSettingsModel() override;
// QAbstractItemModel interface // QAbstractItemModel interface
int rowCount(const QModelIndex &/*parent*/ = QModelIndex()) const final { return m_settings.count(); } int rowCount(const QModelIndex &/*parent*/ = QModelIndex()) const final { return m_settings.count(); }

4
src/plugins/languageclient/languageclientsettings.h
View File

@@ -129,7 +129,7 @@ class BaseSettingsWidget : public QWidget
Q_OBJECT Q_OBJECT
public: public:
explicit BaseSettingsWidget(const BaseSettings* settings, QWidget *parent = nullptr); explicit BaseSettingsWidget(const BaseSettings* settings, QWidget *parent = nullptr);
~BaseSettingsWidget() = default; ~BaseSettingsWidget() override = default;
QString name() const; QString name() const;
LanguageFilter filter() const; LanguageFilter filter() const;
@@ -149,7 +149,7 @@ class StdIOSettingsWidget : public BaseSettingsWidget
Q_OBJECT Q_OBJECT
public: public:
explicit StdIOSettingsWidget(const StdIOSettings* settings, QWidget *parent = nullptr); explicit StdIOSettingsWidget(const StdIOSettings* settings, QWidget *parent = nullptr);
~StdIOSettingsWidget() = default; ~StdIOSettingsWidget() override = default;
QString executable() const; QString executable() const;
QString arguments() const; QString arguments() const;