LanguageClient: Modernize

modernize-*

Change-Id: I966de09934b9ba3b0497d1df5744c8c3f826240f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/languageclient/baseclient.cpp

@@ -609,7 +609,7 @@ void BaseClient::handleMethod(const QString &method, MessageId id, const IConten
         if (paramsValid)
             log(params);
     } else if (method == ShowMessageRequest::methodName) {
-        const ShowMessageRequest *request = dynamic_cast<const ShowMessageRequest *>(content);
+        auto request = dynamic_cast<const ShowMessageRequest *>(content);
         auto params = request->params().value_or(ShowMessageRequestParams());
         paramsValid = params.isValid(&error);
         if (paramsValid) {

src/plugins/languageclient/dynamiccapabilities.h

@@ -33,7 +33,7 @@ class DynamicCapability
 {
 public:
     DynamicCapability() = default;
-    void enable(QString id, QJsonValue options)
+    void enable(const QString &id, const QJsonValue &options)
     {
         QTC_CHECK(!m_enabled);
         m_enabled = true;

src/plugins/languageclient/languageclientmanager.cpp

@@ -290,7 +290,7 @@ void LanguageClientManager::editorOpened(Core::IEditor *iEditor)
     }
 }
 
-void LanguageClientManager::editorsClosed(const QList<Core::IEditor *> editors)
+void LanguageClientManager::editorsClosed(const QList<Core::IEditor *> &editors)
 {
     for (auto iEditor : editors) {
         if (auto editor = qobject_cast<TextEditor::BaseTextEditor *>(iEditor)) {

src/plugins/languageclient/languageclientmanager.h

@@ -49,6 +49,8 @@ class LanguageClientManager : public QObject
 {
     Q_OBJECT
 public:
+    LanguageClientManager(const LanguageClientManager &other) = delete;
+    LanguageClientManager(LanguageClientManager &&other) = delete;
     ~LanguageClientManager() override;
 
     static void init();
@@ -78,11 +80,9 @@ signals:
 
 private:
     LanguageClientManager();
-    LanguageClientManager(const LanguageClientManager &other) = delete;
-    LanguageClientManager(LanguageClientManager &&other) = delete;
 
     void editorOpened(Core::IEditor *editor);
-    void editorsClosed(const QList<Core::IEditor *> editors);
+    void editorsClosed(const QList<Core::IEditor *> &editors);
     void documentContentsSaved(Core::IDocument *document);
     void documentWillSave(Core::IDocument *document);
     void findLinkAt(const Utils::FileName &filePath, const QTextCursor &cursor,

src/plugins/languageclient/languageclientsettings.cpp

@@ -70,7 +70,7 @@ class LanguageClientSettingsModel : public QAbstractListModel
 {
 public:
     LanguageClientSettingsModel() = default;
-    ~LanguageClientSettingsModel();
+    ~LanguageClientSettingsModel() override;
 
     // QAbstractItemModel interface
     int rowCount(const QModelIndex &/*parent*/ = QModelIndex()) const final { return m_settings.count(); }

src/plugins/languageclient/languageclientsettings.h

@@ -129,7 +129,7 @@ class BaseSettingsWidget : public QWidget
     Q_OBJECT
 public:
     explicit BaseSettingsWidget(const BaseSettings* settings, QWidget *parent = nullptr);
-    ~BaseSettingsWidget() = default;
+    ~BaseSettingsWidget() override = default;
 
     QString name() const;
     LanguageFilter filter() const;
@@ -149,7 +149,7 @@ class StdIOSettingsWidget : public BaseSettingsWidget
     Q_OBJECT
 public:
     explicit StdIOSettingsWidget(const StdIOSettings* settings, QWidget *parent = nullptr);
-    ~StdIOSettingsWidget() = default;
+    ~StdIOSettingsWidget() override = default;
 
     QString executable() const;
     QString arguments() const;